Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OnyxNavBar): Replace cursor pointer with default #1901

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MajaZarkova
Copy link
Contributor

@MajaZarkova MajaZarkova commented Sep 30, 2024

Relates to #1614

Replace cursor pointer with default for OnyxNavButton and it's nested items

Checklist

  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@MajaZarkova MajaZarkova requested a review from a team as a code owner September 30, 2024 11:21
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 5eaa9a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Patch
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Patch
@sit-onyx/nuxt Patch
@sit-onyx/storybook-utils Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MajaZarkova MajaZarkova changed the title Fix/1614 replace cursor pointer with default fix(OnyxNavBar): Replace cursor pointer with default Sep 30, 2024
Copy link
Contributor

@JoCa96 JoCa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the NavButtons never show a pointer cursor.
I should still be shown for navbuttons, that have a direct action (aka no children)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants