feat(OnyxTooltip): auto align tooltip #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa3f7a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
please adjust the PR title to the convention :) the pattern is
|
BoppLi
reviewed
Sep 3, 2024
MajaZarkova
requested changes
Sep 3, 2024
packages/sit-onyx/src/components/OnyxTooltip/OnyxTooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxTooltip/OnyxTooltip.stories.ts
Outdated
Show resolved
Hide resolved
ChristianBusshoff
changed the title
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
larsrickert
requested changes
Sep 13, 2024
MajaZarkova
requested changes
Oct 2, 2024
packages/sit-onyx/playwright/snapshots/components/OnyxTooltip/Tooltip-chromium-linux.png
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
larsrickert
requested changes
Oct 15, 2024
packages/sit-onyx/src/components/OnyxTooltip/OnyxTooltip.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxCheckbox/OnyxCheckbox.stories.ts
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: ChristianBusshoff <[email protected]>
larsrickert
requested changes
Oct 18, 2024
...ywright/snapshots/components/OnyxInput/Input-labelTooltip-messageTooltip--chromium-linux.png
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsrickert
previously approved these changes
Oct 24, 2024
|
@ChristianBusshoff Can you add a changeset so this feature is released to the users? |
larsrickert
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Tooltip-Error-Logic (hide tooltip before user interaction) in:
// hide error tooltip before a user interaction happened
.onyx-error-tooltip:has(&__input):not(:has(&__input:user-invalid)) .onyx-tooltip {
display: none;
}