Tim/frame rate #100
Merged
Tim/frame rate #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mouse_down(), mouse_is_pressed and mouse_up docs
Version 0.1.1
Bumped test run
v0.1.2 release
Not sure if this is the right place to put it but I was getting a key error trying to put it as property
tests different cases of trying to re-assign FRAME_RATE
FRAME_RATE is a @Property and an @ignite_global. @FRAME_RATE.setter is supposed to prevent the user from re-assigning.
…tim/frame_rate
|
Somehow our |
AlphaRLee
reviewed
Mar 2, 2021
test/FrameRateTest.ipynb
Outdated
Comment on lines
441
to
450
| "source": [ | ||
| "%%ignite\n", | ||
| "\n", | ||
| "def setup():\n", | ||
| " size(200, 100)\n", | ||
| " background(\"light blue\")\n", | ||
| " FRAME_RATE = 1\n", | ||
| " print(\"frame rate:\", FRAME_RATE)\n", | ||
| " # this prints 1, not what I want\n" | ||
| ] |
There was a problem hiding this comment.
Please clean up tests like these. In this case, just outright delete this and make sure your other comments are ready-to-go
AlphaRLee
reviewed
Mar 2, 2021
test/FrameRateTest.ipynb
Outdated
Comment on lines
652
to
661
| "source": [ | ||
| "%%ignite\n", | ||
| "\n", | ||
| "def setup():\n", | ||
| " size(200, 100)\n", | ||
| " background(\"light blue\")\n", | ||
| " print(\"frame rate:\", FRAME_RATE)\n", | ||
| " FRAME_RATE = 10\n", | ||
| " # this gives an error, FRAME_RATE is referenced before assignment" | ||
| ] |
AlphaRLee
requested changes
Mar 2, 2021
Added a description of FRAME_RATE to utilities.md
AlphaRLee
approved these changes
Mar 11, 2021
AlphaRLee
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please someone have a look at this, not sure if I've done everything right. I made the already existing
FRAME_RATEin core.py accessible to the user by making it an ignite_global. I also added a sentence to the documentation mentioning the frame rate. Closes #81