Implement file index provider #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This powers VSCode's built-in fuzzy file finder.
| @@ -31,7 +31,7 @@ export async function calculateActualConfig(config: FileSystemConfig): Promise<F | |||
| config.host = replaceVariables(config.host); | |||
| const port = replaceVariables((config.port || '') + ''); | |||
| if (port) config.port = Number(port); | |||
| config.agent = replaceVariables(config.agent); | |||
| config.agent = replaceVariables(config.agent) || process.env.SSH_AUTH_SOCK; | |||
There was a problem hiding this comment.
I haven't thought of using this variable, but it's a good idea. If you want, you can make this a separate PR, or let me commit it myself.
|
|
||
| public async provideFileIndex(options: vscode.FileSearchOptions, token: vscode.CancellationToken): Promise<vscode.Uri[]> { | ||
| const name = this.config.label || this.config.name; | ||
| const command = `find ${this.relative(options.folder.path)} -print0`; |
There was a problem hiding this comment.
Have you checked whether this command and syntax is available on all distros that support SFTP?
|
Hey @benesch have you been able to build a version of this plugin with this new search implementation yet? I'd be really great if you could provide us a .vsix package! |
|
I haven't the time, I'm afraid. You'll have to go it yourself. |
SchoofsKelvin
force-pushed
the
master
branch
from
2b9e766 to
284e02f
Compare
SchoofsKelvin
force-pushed
the
master
branch
5 times, most recently
from
fa8c015 to
9be6aa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This powers VSCode's built-in fuzzy file finder.
The approach taken is to execute
findon the remote machine. This is more efficient than the implementation on the insiders branch, which uses SFTP.This implements part of #2. I'm not actually proposing that this be merged yet, since sadly the file finding APIs are still experimental.