Merge 3b0be13 into 9c4c317

SchlossLab · Jan 29, 2022 · 6a743bd · 6a743bd
2 parents 9c4c317 + 3b0be13
commit 6a743bd
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 43 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: mikropml
 Title: User-Friendly R Package for Supervised Machine Learning Pipelines
-Version: 1.2.0.9000
-Date: 2021-11-10
+Version: 1.2.1
+Date: 2022-01-29
 Authors@R: 
     c(person(given = "Begüm",
              family = "Topçuoğlu",

diff --git a/NAMESPACE b/NAMESPACE
@@ -19,7 +19,6 @@ export(get_perf_metric_name)
 export(get_performance_tbl)
 export(get_tuning_grid)
 export(group_correlated_features)
-export(keep_groups_in_cv_partitions)
 export(plot_hp_performance)
 export(plot_model_performance)
 export(preprocess_data)

diff --git a/NEWS.md b/NEWS.md
@@ -1,8 +1,8 @@
-# development version 1.3.0
+# mikropml 1.2.1
 
 - Allow `kfold >= length(groups)` (#285, @kelly-sovacool).
     - When using the groups parameter, groups are kept together in cross-validation partitions when `kfold` <= the number of groups in the training set. Previously, an error was thrown if this condition was not met. Now, if there are not enough groups in the training set for groups to be kept together during CV, groups are allowed to be split up across CV partitions. 
-- Report p-values for permutation feature importance (#288, @kelly-sovacool)
+- Report p-values for permutation feature importance (#288, @kelly-sovacool).
 
 # mikropml 1.2.0
 

diff --git a/R/cross_val.R b/R/cross_val.R
@@ -93,7 +93,7 @@ get_seeds_trainControl <- function(hyperparams_list, kfold, cv_times, ncol_train
 #' @inheritParams define_cv
 #'
 #' @return `TRUE` if possible, `FALSE` otherwise
-#' @export
+#' @noRd
 #' @author Kelly Sovacool, \email{sovacool@@umich.edu}
 #'
 keep_groups_in_cv_partitions <- function(groups, group_partitions, kfold) {

diff --git a/cran-comments.md b/cran-comments.md
@@ -17,7 +17,7 @@
     Message: Bad Request
 ```
 
-I believe this is a spurious note as the URL works in my local browser.
+This is a spurious note as the URL works in my local browser.
 
 ## revdepcheck results
 

diff --git a/man/keep_groups_in_cv_partitions.Rd b/man/keep_groups_in_cv_partitions.Rd