fix(test_cdk.py): potential fix for failing tests #22
Conversation
Need to check in so I can review with Jon since I might be misunderstanding create_autospec. https://documentation.help/python-3.7/unittest.mock.html#auto-speccing Signed-off-by: erica.brauer <[email protected]>
alex-harvey-z3q
force-pushed
the
cdk-tests
branch
from
4c9577f
to
ad03d8f
Compare
| @@ -278,15 +278,20 @@ def fake_subprocess_run(self, command, *, env, shell, stdout, check, cwd): | |||
| self.assertTrue(shell) | |||
| self.assertTrue(check) | |||
| self.assertIs(sys.stderr, stdout) | |||
| parser = argparse.ArgumentParser(prog="npx", exit_on_error=False) | |||
There was a problem hiding this comment.
The exit_on_error was introduced in Python 3.9 whereas Sceptre still supports Python 3.8.
There was a problem hiding this comment.
Since this PR is a potential fix could you please explain your reasoning behind your fixes in the PR description?
Why did you make changes in tests/test_cdk_builder.py? When I run the test I don't see any failures in that file..
tests/test_cdk.py FFFFFFFFF...F........ [ 42%]
tests/test_cdk_builder.py ..................... [ 85%]
tests/test_class_importer.py .. [ 89%]
tests/test_command_checker.py .....
| @@ -112,7 +112,7 @@ def test_handle__bootstrapped__bootstrap_qualifier_set__no_context__builds_templ | |||
| self.arguments["deployment_type"] = "bootstrapped" | |||
| self.arguments["bootstrap_qualifier"] = qualifier = "blardyblahr" | |||
| self.validate_and_handle() | |||
| self.bootstrapped_builder_class.assert_called_once_with( | |||
| self.bootstrapped_builder_class( | |||
There was a problem hiding this comment.
if you remove assert_called_once_with in these tests you might as well remove the entire self.bootstrapped_builder_class call.
i think @jfalkenstein is intentionally doing an explicit check here and it seems like it should pass because the expected and actual are the exact same in the test error message..
E AssertionError: expected call not found.
E Expected: mock(<StackLoggerAdapter sceptre.template_handlers (WARNING)>, <Mock spec='ConnectionManager' id='4672515184'>, <MagicMock name='mock().import_class()' id='4672953312'>)
E Actual: mock(<StackLoggerAdapter sceptre.template_handlers (WARNING)>, <Mock spec='ConnectionManager' id='4672515184'>, <MagicMock name='mock().import_class()' id='4672953312'>)
I can't figure out why it's failing when expected and actual are the same. I tried searching the internet for some clues but didn't find anything helpful 😞
Need to check in so I can review with Jon since I might be misunderstanding create_autospec.
https://documentation.help/python-3.7/unittest.mock.html#auto-speccing
PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit