-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/271/issue with starting the service since graceful udate #273
Merged
sc-zenokerr
merged 14 commits into
master
from
fix/271/Issue-with-starting-the-service-since-graceful-udate
Aug 22, 2024
Merged
Fix/271/issue with starting the service since graceful udate #273
sc-zenokerr
merged 14 commits into
master
from
fix/271/Issue-with-starting-the-service-since-graceful-udate
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to Scalingo/go-utils#944
…-service-since-graceful-udate # Conflicts: # go.mod # go.sum # vendor/github.com/Scalingo/go-utils/graceful/CHANGELOG.md # vendor/modules.txt
Related to Scalingo/go-utils#944 Finalise merge of master
Related to Scalingo/go-utils#944 Lint
Related to Scalingo/go-utils#944 Lint
Related to Scalingo/go-utils#944 With etienne's expert eye
Related to Scalingo/go-utils#944 Fix TLS config initialisation
Fixes #271 Related to Scalingo/go-utils#944
sc-zenokerr
requested review from
EtienneM and
curzolapierre
and removed request for
curzolapierre and
EtienneM
August 16, 2024 05:59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Cédric Thomas <[email protected]>
Soulou
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with success
sc-zenokerr
deleted the
fix/271/Issue-with-starting-the-service-since-graceful-udate
branch
August 22, 2024 08:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
Related to Scalingo/go-utils#944
Related to STORY-828