-
Notifications
You must be signed in to change notification settings - Fork 10
[FE] Analytics - Progress bars & co. #117
base: master
Are you sure you want to change the base?
Conversation
…connected to allcourses, but they still function and present the information needed. all we need to do now is replace datasets>data with the relevant information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, that's an important feature!
Please see the comments and comment so we can merge this soon
label: "total points", | ||
backgroundColor: "#999999", | ||
fill: false, | ||
data: [0,25, 56, 70, 80, 90, 105, 125, 134], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
134
? What's this? (as well as all other hardcoded values)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the number of points required for completing a CS degree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Does the order mean anything?
- is it hardcoded for development purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- no, it approximates the cummulative number of points up to the appropriate semseter
- it is hardcoded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why?
mounted () { | ||
// Overwriting base render method with actual data. | ||
this.renderChart({ | ||
labels: ['Must', 'Choose from list', 'Choice'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have CornerStone
and Complementary
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, what are the numbers representing their types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need this also for the progress bars, even though complementary courses would probably not appear there, as there is no quota of them that needs to be filled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of numbers representing types on the backend, I guess someone created such a mapping somewhere in the FE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Track
model does have the quota, is it missing from the API?
datasets: [ | ||
{ | ||
backgroundColor: ['#bc87d0','#fbaf5d','#f06eaa'], | ||
data: [70, 20, 40] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do these values mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an approximate distribution of your points on a standard single major degree, it's just a dummy graph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a dummy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because untill we find a way communicating the data between different views, i can't access them from the analytics view. thats an architectural decision that noa should do i believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this feature as part of this PR necessary for creating the infrastructure?
- Can we hide it until it's ready? (so
master
doesn't have half-baked features)
mounted () { | ||
// Overwriting base render method with actual data. | ||
this.renderChart({ | ||
labels: ['Must', 'Choose from list', 'Choice'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we handle cases when one category (or more) require 0 points (so - isn't required)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this graph it really doesn't matter as they just won't appear, but in the progress bars i'll probably need to drop the cornerStones bar when a certain track is taken (like cognition, which doesn't require corner stones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, please do, and notice various courses may even have 0 choice
or 0 from_list
(do I hear a 0 must
?)
Does it close any existing issues? if so, please mention them ( |
Added an additional view for analytics with some dummy charts,
and a functional progress bar.