Skip to content

Commit

Permalink
adding handling for xivapi missing items
Browse files Browse the repository at this point in the history
  • Loading branch information
freyamade committed Jul 17, 2024
1 parent 8d184b8 commit cca0476
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions backend/api/views/xivgear.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ def get(self, request: Request, id: str) -> Response:
gear_names = XIVAPISearchClient.get_item_information(*sa_gear.values())
except requests.HTTPError as e:
return Response({'message': e.response.text}, 400)

if len(gear_names) != len(sa_gear):
return Response({'message': 'XIVAPI appears to be missing gear information, please try again later!'}, 400)

# Use the returned map to calculate the min and max ils, and also replace IDs with names in sa_gear
min_il = float('inf')
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/modals/changelog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
<p>This set of documentation is mostly manually written so if there are any questions, feel free to ask on Discord/Github!</p>

<div class="divider"><i class="material-icons icon">expand_more</i> Fixes &amp; Improvements <i class="material-icons icon">expand_more</i></div>
<p>Fixed handling issues when XIVApi has not been updated with new items yet, when trying to import XIVGear sets.</p>
<p>Fixed a bug causing the popup generated by the "Add New" button on the Team Membership forms to not display any information.</p>
<p>Improved fetching of Teams from the database to improve speed and lessen the load on the server.</p>
<p>Added "API Schema" and "Plugin" links to the footer icons.</p>
Expand Down

0 comments on commit cca0476

Please sign in to comment.