forked from dhis2/dhis2-android-capture-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daub 40 - Get and store media details from server to local #23
Open
NelsonChad
wants to merge
6
commits into
develop
Choose a base branch
from
DAUB-40
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit b15ee7d Author: Job Guitiche <[email protected]> Date: Wed Nov 15 19:54:57 2023 -0300 refactor: removes logs commit dffe085 Author: Job Guitiche <[email protected]> Date: Wed Nov 15 19:42:50 2023 -0300 refactor: remove logs commit 7485b4c Author: Job Guitiche <[email protected]> Date: Wed Nov 15 19:30:44 2023 -0300 fix: bug checking local media file commit 1d786da Author: Job Guitiche <[email protected]> Date: Tue Nov 7 22:05:48 2023 -0300 feat: testing functions commit 13ca2b2 Author: Job Guitiche <[email protected]> Date: Tue Nov 7 16:09:10 2023 -0300 feat: check internet connection before call media dialog commit 2f60eba Author: Job Guitiche <[email protected]> Date: Fri Nov 3 20:49:57 2023 -0300 DAUB-29 improvements (#22) * fix 404 request error exception * wip: improve loading state * fix: error showing media dialog - 'checkDataElement()' improvement - Changes 'println(x)' to 'timber.d(x) - General code clean up - fix bugs on calling 'MediaDialog' * feat: show error message for invalid media file paths * wip: split functions to reformat the code * wip: clean code * fix: multiples dialogs appears after second click * refactor: change function access - 'getFileExtension()' - 'downloadMedia()' * refactor: clean up 'downloadMedia()' function * feat: create a function 'createDownloadDirectory()' * refactor: create 'createMediaFilePath()' function * refactor: adds 'saveMediaToFile()' function --------- Co-authored-by: Nelson Chadali <[email protected]> commit 47a3ed8 Author: Job Guitiche <[email protected]> Date: Thu Nov 2 00:56:20 2023 -0300 feat: improves media dialog commit 8e87b5c Author: Job Guitiche <[email protected]> Date: Wed Nov 1 18:52:24 2023 -0300 feat: implements loading media dialog commit 38dc2c3 Author: Job Guitiche <[email protected]> Date: Tue Oct 31 10:22:01 2023 -0300 refactor: basic clean up commit 9b0fe93 Author: Job Guitiche <[email protected]> Date: Tue Oct 31 09:43:08 2023 -0300 feat: more uids tests commit 7e61210 Merge: 7e3e7ee 916b8b9 Author: Job Guitiche <[email protected]> Date: Tue Oct 31 09:28:24 2023 -0300 Merge branch 'develop' into DAUB-29 commit 7e3e7ee Author: Job Guitiche <[email protected]> Date: Tue Oct 31 09:15:38 2023 -0300 feat: working code! commit 91f52d7 Author: Job Guitiche <[email protected]> Date: Mon Oct 30 22:43:42 2023 -0300 Squashed commit of the following: commit 7465ac9 Author: Nelson Chadali <[email protected]> Date: Tue Oct 31 03:38:50 2023 +0200 Daub 25- download media (#18) * Configurando os dados para baixar media * Add download media feature * fix download method and getLocalFile * remove comments and uneccessary code * add return to getLocalMedia and remove aneccessary code] --------- Co-authored-by: Miguel Vasco Macamo <[email protected]> commit 4e0137c Author: Job Guitiche <[email protected]> Date: Mon Oct 30 22:43:12 2023 -0300 refactor: simple improvements commit f8268b7 Author: Job Guitiche <[email protected]> Date: Fri Oct 27 22:31:22 2023 -0300 feat: testing data store implementation commit 3d54a67 Merge: 3acac01 a72a3f5 Author: Job Guitiche <[email protected]> Date: Fri Oct 27 17:44:16 2023 -0300 Merge branch 'develop' into DAUB-29 commit 3acac01 Merge: fa27519 f9768a9 Author: Job Guitiche <[email protected]> Date: Thu Oct 26 10:20:26 2023 -0300 Merge branch 'develop' into DAUB-29 commit fa27519 Author: Job Guitiche <[email protected]> Date: Wed Oct 25 23:09:09 2023 -0300 refactor: ktlint format commit 25ff1a0 Author: Job Guitiche <[email protected]> Date: Wed Oct 25 23:06:18 2023 -0300 feat: code optimizations commit f0d79b1 Author: Job Guitiche <[email protected]> Date: Wed Oct 25 21:11:28 2023 -0300 feat: uses data element data commit cfc4333 Author: Job Guitiche <[email protected]> Date: Tue Oct 24 16:11:56 2023 -0300 feat: update 'showDescriptionLabelDialog()' function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and include the related jira issue if it exists.
[ jira issue ](https://dhis2.atlassian.net/browse/ANDROAPP-
Solution description
If this PR is a fix include a brief description on how the issue is solved.
Covered unit test cases
Describe the tests that you ran to verify your changes.
Where did you test this issue?
Which Android versions did you test this issue?
Checklist