DAUB-29 #15
Open
DAUB-29 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonChad
requested changes
Oct 26, 2023
NelsonChad
previously requested changes
Oct 27, 2023
commit 7465ac9 Author: Nelson Chadali <[email protected]> Date: Tue Oct 31 03:38:50 2023 +0200 Daub 25- download media (#18) * Configurando os dados para baixar media * Add download media feature * fix download method and getLocalFile * remove comments and uneccessary code * add return to getLocalMedia and remove aneccessary code] --------- Co-authored-by: Miguel Vasco Macamo <[email protected]>
* fix 404 request error exception * wip: improve loading state * fix: error showing media dialog - 'checkDataElement()' improvement - Changes 'println(x)' to 'timber.d(x) - General code clean up - fix bugs on calling 'MediaDialog' * feat: show error message for invalid media file paths * wip: split functions to reformat the code * wip: clean code * fix: multiples dialogs appears after second click * refactor: change function access - 'getFileExtension()' - 'downloadMedia()' * refactor: clean up 'downloadMedia()' function * feat: create a function 'createDownloadDirectory()' * refactor: create 'createMediaFilePath()' function * refactor: adds 'saveMediaToFile()' function --------- Co-authored-by: Nelson Chadali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR check if
DataElementhaveFileResourcesdata and if exist use them to showMediaDialogFragment. If not, show a simpleCostumDialog.jira issue
Solution description
val dataElement = getD2().dataElement(intent.uid)Using this code, I was able to access the
DataElementdata after hours of debugging.Covered unit test cases
Where did you test this issue?
Which Android versions did you test this issue?
Checklist