Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Autoplay next song in search list #501

Merged

Conversation

The-Phoenics
Copy link
Contributor

Description

When user plays a song from song search results the next song in the list now automatically plays when the current song ends.

Related Issues

Video

2024-07-25.14-13-31.mp4

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 8:50am

Copy link

vercel bot commented Jul 25, 2024

@The-Phoenics is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @The-Phoenics! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@The-Phoenics
Copy link
Contributor Author

@saurabhsingh720 @Satyam1923
Can you please review the PR?

@saurabhsingh720 saurabhsingh720 added question Further information is requested gssoc labels Jul 26, 2024
@saurabhsingh720
Copy link
Contributor

@The-Phoenics till your PR doesnot show what u have solved.
it is showing same as the previous state (songs donot autoplayed)
check it

@The-Phoenics
Copy link
Contributor Author

Hey @saurabhsingh720
Did you review it in the deployed version of this PR? Or in the attached video?

@The-Phoenics
Copy link
Contributor Author

@saurabhsingh720
Can you check again I've resolved the merge conflicts and next song autoplay is working for me.

@saurabhsingh720 saurabhsingh720 merged commit 9784879 into Satyam1923:master Jul 28, 2024
3 of 4 checks passed
@saurabhsingh720 saurabhsingh720 added enhancement New feature or request level1 and removed question Further information is requested labels Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Search page - Autoplay next song after song ends
2 participants