Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Libvirt secureboot provisioning #17136

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Add tests for Libvirt secureboot provisioning #17136

merged 3 commits into from
Jan 8, 2025

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Missing test coverage for new feature of Libvirt UEFI and secureboot provisioning

Solution

Add and update existing tests to include Libvirt UEFI and secureboot provisioning

Related Issues

https://issues.redhat.com/browse/SAT-25808

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Dec 10, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Dec 10, 2024
@Gauravtalreja1 Gauravtalreja1 requested review from a team as code owners December 10, 2024 09:16
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9570
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 7 failed, 2 passed, 64 deselected, 649 warnings in 12106.15s (3:21:46) ====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 10, 2024
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9582
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 7 failed, 2 passed, 64 deselected, 659 warnings in 12334.22s (3:25:34) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9597
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 6 failed, 3 passed, 64 deselected, 704 warnings in 11726.42s (3:15:26) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9655
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 2 failed, 7 passed, 64 deselected, 773 warnings in 12005.42s (3:20:05) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9665
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 2 failed, 7 passed, 64 deselected, 772 warnings in 12734.74s (3:32:14) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9679
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : = 2 failed, 4 passed, 64 deselected, 751 warnings, 3 errors in 8353.04s (2:19:13) =

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9684
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : = 2 failed, 4 passed, 64 deselected, 574 warnings, 4 errors in 7931.81s (2:12:11) =

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9687
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 3 failed, 6 passed, 64 deselected, 771 warnings in 12192.21s (3:23:12) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9689
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 3 failed, 6 passed, 64 deselected, 774 warnings in 12040.01s (3:20:40) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9691
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ==== 3 failed, 6 passed, 64 deselected, 772 warnings in 12154.39s (3:22:34) ====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9703
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 3 passed, 1 deselected, 107 warnings in 3548.63s (0:59:08) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 23, 2024
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 26, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9708
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ===== 1 failed, 2 passed, 1 deselected, 106 warnings in 3768.29s (1:02:48) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Dec 26, 2024
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9716
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : ========== 3 passed, 1 deselected, 109 warnings in 3611.21s (1:00:11) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Dec 27, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Dec 30, 2024
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end
provisioning: true
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9721
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/{api,cli,ui}/test_computeresource_libvirt.py -k test_positive_provision_end_to_end --external-logging --include-onprem-provisioning
Test Result : === 6 failed, 6 passed, 64 deselected, 1315 warnings in 17228.96s (4:47:08) ====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jan 2, 2025
@Gauravtalreja1
Copy link
Collaborator Author

PRT failures with EL10 are caused by known bug, and other failures are intermittent failures, so this PR is ready for review now

nofaralfasi
nofaralfasi reviewed Jan 8, 2025
View reviewed changes
Copy link

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

shubhamsg199
shubhamsg199 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, EL10 failures are expected because of a known bug

@shubhamsg199 shubhamsg199 merged commit 7b789cb into SatelliteQE:master Jan 8, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nofaralfasi nofaralfasi nofaralfasi left review comments

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR QETestCoverage Issues and PRs relating to a Satellite bug Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @nofaralfasi @shubhamsg199