Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

role should ignore while import #16873

Merged
merged 1 commit into from
Nov 6, 2024
Merged

role should ignore while import #16873

merged 1 commit into from
Nov 6, 2024

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Nov 5, 2024 •
edited
Loading

The ignore list setting prevents selected roles from being available for import

Dependent PR: SatelliteQE/airgun#1620

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 5, 2024
@amolpati30 amolpati30 requested a review from a team as a code owner November 5, 2024 18:36
@amolpati30 amolpati30 mentioned this pull request Nov 5, 2024
Merged
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9283
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_ansible_roles_ignore_list --external-logging
Test Result : ========== 1 passed, 10 deselected, 19 warnings in 575.11s (0:09:35) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 5, 2024
Gauravtalreja1
Gauravtalreja1 reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, with a few minor comments

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 6, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_ansible_roles_ignore_list
airgun: 1620

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9289
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_ansible_roles_ignore_list --external-logging
Test Result : ========== 1 passed, 10 deselected, 19 warnings in 523.79s (0:08:43) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 6, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit d1efa75 into SatelliteQE:master Nov 6, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@amolpati30 @web-flow
role should ignore while import (#16873)
c1111c6 
(cherry picked from commit d1efa75)
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@amolpati30 @web-flow
role should ignore while import (#16873)
2214330 
(cherry picked from commit d1efa75)
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
@amolpati30 @web-flow
role should ignore while import (#16873)
7a97f32 
(cherry picked from commit d1efa75)
This was referenced Nov 6, 2024
Merged
Closed
Merged
Merged
Merged
This was referenced Nov 7, 2024
Merged
Merged
Merged
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Nov 8, 2024
@amolpati30 @damoore044
role should ignore while import (SatelliteQE#16873)
bfeba86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@amolpati30 amolpati30

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amolpati30 @Satellite-QE @Gauravtalreja1