Fix Discovery Tests #16605

shweta83 · 2024-10-08T04:22:08Z

Problem Statement

Discovery tests were failing with hussh backend as the shell didn't have stdout attribute and also because of a bug in hussh: JacobCallahan/Hussh#26

Solution

Updated the tests to exit the shell contextmanager and read shell.result.stdout. Also, because of the bug, we need to explicitly close the shell before exiting contextmanager.

Related Issues

shweta83 · 2024-10-08T04:23:10Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host[rhel8-ipv4-bios-discovery]
"provisioning": true

Satellite-QE · 2024-10-08T04:41:22Z

PRT Result

Build Number: 8889
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host[rhel8-ipv4-bios-discovery] --external-logging
Test Result : =========== 1 deselected, 10 warnings, 1 error in 617.93s (0:10:17) ============

shweta83 · 2024-10-08T04:55:19Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host
"provisioning": true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'

shweta83 · 2024-10-08T06:17:47Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'

Satellite-QE · 2024-10-08T06:19:36Z

PRT Result

Build Number: 8890
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging
Test Result : ========== 4 deselected, 35 warnings, 4 errors in 4738.30s (1:18:58) ===========

Gauravtalreja1 · 2024-10-08T07:59:26Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'
    BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-10-08T09:24:15Z

PRT Result

Build Number: 8898
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4722.20s (1:18:42) ==================

Satellite-QE · 2024-10-09T00:33:15Z

PRT Result

Build Number: 8908
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4706.57s (1:18:26) ==================

shweta83 · 2024-10-24T10:43:58Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'
    BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-10-24T12:10:54Z

PRT Result

Build Number: 9138
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4744.65s (1:19:04) ==================

Satellite-QE · 2024-10-24T15:30:49Z

PRT Result

Build Number: 9144
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 33 warnings, 4 errors in 4628.24s (1:17:08) ==================

shweta83 · 2024-11-12T06:46:41Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '9'
    BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-11-12T08:11:34Z

PRT Result

Build Number: 9329
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4775.78s (1:19:35) ==================

Satellite-QE · 2024-11-12T10:45:41Z

PRT Result

Build Number: 9331
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4760.52s (1:19:20) ==================

Satellite-QE · 2024-11-12T12:37:55Z

PRT Result

Build Number: 9334
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 35 warnings, 4 errors in 4774.49s (1:19:34) ==================

Satellite-QE · 2024-11-12T14:18:12Z

PRT Result

Build Number: 9336
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py::TestDiscoveredHost::test_positive_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ================= 4 passed, 389 warnings in 3366.96s (0:56:06) =================

shubhamsg199

Ack, PRT 9336 passed

shweta83 · 2024-11-13T09:29:38Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning
provisioning: true
env:
    BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-11-13T11:31:51Z

PRT Result

Build Number: 9345
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning --external-logging --include-onprem-provisioning
Test Result : = 5 failed, 9 passed, 1 deselected, 1428 warnings, 1 error in 6892.35s (1:54:52) =

Gauravtalreja1 · 2024-11-13T12:11:56Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning -m on_premises_provisioning
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '9'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'
    BROKER_SSH_BACKEND: hussh

Gauravtalreja1 · 2024-11-13T12:13:52Z

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning -m on_premises_provisioning
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '9'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'
    BROKER_SSH_BACKEND: hussh

Satellite-QE · 2024-11-13T14:12:32Z

PRT Result

Build Number: 9347
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning -m on_premises_provisioning --external-logging --include-onprem-provisioning
Test Result : ==== 1 failed, 9 passed, 5 deselected, 1331 warnings in 6593.00s (1:49:52) =====

(cherry picked from commit 41ec8b6)

Fix Discovery Tests (#16605) (cherry picked from commit 41ec8b6) Co-authored-by: Shweta Singh <[email protected]>

shweta83 requested a review from a team as a code owner October 8, 2024 04:22

github-actions bot assigned shweta83 Oct 8, 2024

shweta83 added CherryPick PR needs CherryPick to previous branches 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 8, 2024

shweta83 marked this pull request as draft October 8, 2024 04:23

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 8, 2024

shweta83 force-pushed the discovery_test branch from 2767d4a to 0858657 Compare October 24, 2024 10:42

shweta83 force-pushed the discovery_test branch from 0858657 to ecdd7ea Compare October 28, 2024 13:18

shweta83 force-pushed the discovery_test branch from ecdd7ea to 36c6a43 Compare November 12, 2024 06:35

shweta83 marked this pull request as ready for review November 12, 2024 06:45

shweta83 requested a review from a team as a code owner November 12, 2024 06:45

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Nov 12, 2024

shweta83 force-pushed the discovery_test branch from 36c6a43 to 963e8c6 Compare November 12, 2024 16:36

Fix Discovery Tests

3e8cb76

shweta83 force-pushed the discovery_test branch from 30cfc18 to 3e8cb76 Compare November 13, 2024 07:54

shubhamsg199 approved these changes Nov 13, 2024

View reviewed changes

SatelliteQE deleted a comment from shweta83 Nov 13, 2024

amolpati30 self-requested a review November 13, 2024 08:27

amolpati30 approved these changes Nov 13, 2024

View reviewed changes

Gauravtalreja1 approved these changes Nov 13, 2024

View reviewed changes

Gauravtalreja1 merged commit 41ec8b6 into SatelliteQE:master Nov 13, 2024
13 of 14 checks passed

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024

Fix Discovery Tests (#16605)

4f04f93

(cherry picked from commit 41ec8b6)

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024

Fix Discovery Tests (#16605)

3f03160

(cherry picked from commit 41ec8b6)

This was referenced Nov 13, 2024

[6.15.z] Fix Discovery Tests #16904

Merged

[6.14.z] Fix Discovery Tests #16905

Merged

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024

Fix Discovery Tests (#16605)

7632c5a

(cherry picked from commit 41ec8b6)

Satellite-QE mentioned this pull request Nov 13, 2024

[6.13.z] Fix Discovery Tests #16906

Merged

github-actions bot pushed a commit that referenced this pull request Nov 13, 2024

Fix Discovery Tests (#16605)

96e44bf

(cherry picked from commit 41ec8b6)

Satellite-QE mentioned this pull request Nov 13, 2024

[6.16.z] Fix Discovery Tests #16907

Merged

Gauravtalreja1 pushed a commit that referenced this pull request Nov 13, 2024

[6.16.z] Fix Discovery Tests (#16907)

f206c95

Fix Discovery Tests (#16605) (cherry picked from commit 41ec8b6) Co-authored-by: Shweta Singh <[email protected]>

Gauravtalreja1 pushed a commit that referenced this pull request Nov 13, 2024

[6.15.z] Fix Discovery Tests (#16904)

b2e175d

Fix Discovery Tests (#16605) (cherry picked from commit 41ec8b6) Co-authored-by: Shweta Singh <[email protected]>

Gauravtalreja1 pushed a commit that referenced this pull request Nov 13, 2024

[6.13.z] Fix Discovery Tests (#16906)

b813a43

Fix Discovery Tests (#16605) (cherry picked from commit 41ec8b6) Co-authored-by: Shweta Singh <[email protected]>

Gauravtalreja1 pushed a commit that referenced this pull request Nov 13, 2024

[6.14.z] Fix Discovery Tests (#16905)

725a7a5

Fix Discovery Tests (#16605) (cherry picked from commit 41ec8b6) Co-authored-by: Shweta Singh <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Discovery Tests #16605

Fix Discovery Tests #16605

shweta83 commented Oct 8, 2024 •

edited

Loading

shweta83 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

shweta83 commented Oct 8, 2024

shweta83 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

Gauravtalreja1 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

Satellite-QE commented Oct 9, 2024

shweta83 commented Oct 24, 2024

Satellite-QE commented Oct 24, 2024

Satellite-QE commented Oct 24, 2024

shweta83 commented Nov 12, 2024 •

edited

Loading

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

shubhamsg199 left a comment

shweta83 commented Nov 13, 2024

Satellite-QE commented Nov 13, 2024

Gauravtalreja1 commented Nov 13, 2024

Gauravtalreja1 commented Nov 13, 2024

Satellite-QE commented Nov 13, 2024

Fix Discovery Tests #16605

Fix Discovery Tests #16605

Conversation

shweta83 commented Oct 8, 2024 • edited Loading

Problem Statement

Solution

Related Issues

shweta83 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

shweta83 commented Oct 8, 2024

shweta83 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

Gauravtalreja1 commented Oct 8, 2024

Satellite-QE commented Oct 8, 2024

Satellite-QE commented Oct 9, 2024

shweta83 commented Oct 24, 2024

Satellite-QE commented Oct 24, 2024

Satellite-QE commented Oct 24, 2024

shweta83 commented Nov 12, 2024 • edited Loading

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

Satellite-QE commented Nov 12, 2024

shubhamsg199 left a comment

Choose a reason for hiding this comment

shweta83 commented Nov 13, 2024

Satellite-QE commented Nov 13, 2024

Gauravtalreja1 commented Nov 13, 2024

Gauravtalreja1 commented Nov 13, 2024

Satellite-QE commented Nov 13, 2024

shweta83 commented Oct 8, 2024 •

edited

Loading

shweta83 commented Nov 12, 2024 •

edited

Loading