Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for SAT-26014 #16522

Merged

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Missing test coverage for SAT-26014

Solution

Adding a destructive test to cover SAT-26014

Related Issues

Signed-off-by: Gaurav Talreja <[email protected]>
@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 27, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Sep 27, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner September 27, 2024 07:54
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py -k test_negative_installer_invalid_dns_forwarder

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8823
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_installer.py -k test_negative_installer_invalid_dns_forwarder --external-logging
Test Result : ========== 1 passed, 5 deselected, 18 warnings in 1252.58s (0:20:52) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 27, 2024
Copy link
Contributor

@rmynar rmynar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just non-blocking comments:
Would you consider adding a positive scenario? It may be easily added into non-default installation:

What about cherry picking into older versions? 6.15, maybe 6.14...?

@Gauravtalreja1
Copy link
Collaborator Author

@rmynar Thanks for your comments.
If you see the related issue, then its about a negative scenario only which breaks the answer file, and for positive scenario its already been tested in our misc-provisioning Jenkins jobs, so I don't think if we should cover in new test separately, and about cherrypicking it to 6.15 or 6.14, so its only fixed for stream and 6.16 for now.

Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, looks good.

@shubhamsg199 shubhamsg199 merged commit 58ac7c9 into SatelliteQE:master Sep 30, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 58ac7c9)
@Gauravtalreja1 Gauravtalreja1 deleted the invalid-dns-forwarders branch September 30, 2024 21:30
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants