Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix AK tests assertion errors (#16220) #16273

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[6.15.z] Fix AK tests assertion errors (#16220) #16273

merged 1 commit into from
Sep 10, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Sep 9, 2024

Manual cherry-pick of #16220

Closes #16262

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Sep 9, 2024
@vsedmik vsedmik self-assigned this Sep 9, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Sep 9, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_create_content_and_check_enabled or test_positive_add_custom_product'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8522
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_create_content_and_check_enabled or test_positive_add_custom_product --external-logging
Test Result : ========= 2 failed, 145 deselected, 178 warnings in 676.87s (0:11:16) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 9, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8523
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_create_content_and_check_enabled or test_positive_add_custom_product --external-logging
Test Result : ==== 1 failed, 1 passed, 145 deselected, 178 warnings in 731.68s (0:12:11) =====

@vsedmik
Fix AK tests assertion errors (SatelliteQE#16220)
c8808d1 
* Fix AK tests assertion errors

* Use default_rhel_version and content_hosts fixture

* Remove obsoleted settings decorator
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8527
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_create_content_and_check_enabled or test_positive_add_custom_product --external-logging
Test Result : ========= 2 passed, 145 deselected, 184 warnings in 732.27s (0:12:12) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Sep 9, 2024
vsedmik
vsedmik commented Sep 9, 2024
View reviewed changes
tests/foreman/cli/test_activationkey.py
)
assert content[0]['default-enabled?'] == 'true'
assert content[0]['default-enabled?'] == 'false'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom content is disabled by default in 6.15, see https://docs.redhat.com/en/documentation/red_hat_satellite/6.15/html-single/managing_content/index#Restricting_Hosts_Access_to_Content_content-management

@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/cli/test_activationkey.py -k 'test_positive_create_content_and_check_enabled or test_positive_add_custom_product'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8541
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_activationkey.py -k test_positive_create_content_and_check_enabled or test_positive_add_custom_product --external-logging
Test Result : ========= 2 passed, 145 deselected, 178 warnings in 687.96s (0:11:27) ==========

@vsedmik vsedmik merged commit 6454bae into SatelliteQE:6.15.z Sep 10, 2024
13 checks passed
@vsedmik vsedmik deleted the 6.15.z-fix-ak branch September 10, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsedmik vsedmik

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @Satellite-QE @Gauravtalreja1