Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for BZ:2238952 and BZ:2025523 #15205

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Add test coverage for BZ:2238952 and BZ:2025523 #15205

merged 1 commit into from
Jun 19, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented May 28, 2024 •
edited
Loading

Problem Statement

Missing coverage for BZ:2238952 and BZ:2268544, where we verified Customize host button works to provision a discovered host with a few customizations.

Solution

Add test coverage for BZ:2238952 and BZ:2268544, to verify functionality of discovery provisioning with Customize host button with a few customizations, and also covering BZ:2025523 where we've validated the assigned Ansible roles to a HostGroup gets auto executed when host is provisioned.
Also, verifying new test and modifying existing test to validate if provisioning is sucessfull on new host UI instead of old UI

Related Issues

SatelliteQE/airgun#1397

@Gauravtalreja1 Gauravtalreja1 added UI Issues and PRs involving the UI QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 28, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this May 28, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner May 28, 2024 22:29
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
airgun: 1397

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7154
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ===== 2 failed, 2 passed, 5 deselected, 409 warnings in 4564.54s (1:16:04) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 28, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
airgun: 1397

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7155
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ===== 2 failed, 2 passed, 5 deselected, 415 warnings in 4271.81s (1:11:11) =====

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
airgun: 1397

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
airgun: 1397
theforeman:
    foreman: 10169

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7169
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : =========== 5 deselected, 14 warnings, 4 errors in 582.79s (0:09:42) ===========

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Jun 10, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
deploy_rhel_version: '9'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7338
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ===== 4 failed, 5 deselected, 809 warnings, 1 error in 9364.63s (2:36:04) ======

@Gauravtalreja1 Gauravtalreja1 force-pushed the discovery-custom-provision branch 2 times, most recently from 7cdf809 to f468cfd Compare June 10, 2024 23:05
@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7341
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ===== 4 failed, 5 deselected, 618 warnings, 4 errors in 4462.36s (1:14:22) =====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7347
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ===== 4 failed, 5 deselected, 638 warnings, 2 errors in 8843.82s (2:27:23) =====

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7365
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 155 warnings in 3740.64s (1:02:20) ==========

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7366
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 174 warnings in 4649.28s (1:17:29) ==========

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
env:
    BROKER_SSH_BACKEND: hussh
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '8'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.15.1'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '2.0'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7370
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 170 warnings in 4481.14s (1:14:41) ==========

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7435
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 174 warnings in 4384.31s (1:13:04) ==========

@Gauravtalreja1
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host
provisioning: true
deploy_rhel_version: '9'
env:
     BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7437
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_discoveredhost.py -k test_positive_custom_provision_pxe_host --external-logging --include-onprem-provisioning
Test Result : ========== 2 failed, 7 deselected, 171 warnings in 4316.77s (1:11:56) ==========

@Gauravtalreja1
Copy link
Collaborator Author

PRT failures occur due to a known bug after provisioning, so this PR can now be reviewed/merged

shubhamsg199
shubhamsg199 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, the failures are expected due to the provisioning bug SAT-25789

@shubhamsg199 shubhamsg199 merged commit c3d4f63 into SatelliteQE:master Jun 19, 2024
8 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:2238952 and BZ:2025523 (#15205)
bb14de6 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c3d4f63)
@Satellite-QE Satellite-QE mentioned this pull request Jun 19, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the discovery-custom-provision branch June 20, 2024 09:58
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Jun 20, 2024
@Gauravtalreja1
Add test coverage for BZ:2238952 and BZ:2025523 (SatelliteQE#15205)
c3ce713 
Signed-off-by: Gaurav Talreja <[email protected]>
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Jun 21, 2024
@Gauravtalreja1
Add test coverage for BZ:2238952 and BZ:2025523 (SatelliteQE#15205)
1464e59 
Signed-off-by: Gaurav Talreja <[email protected]>
Gauravtalreja1 added a commit to Gauravtalreja1/robottelo that referenced this pull request Jun 25, 2024
@Gauravtalreja1
Add test coverage for BZ:2238952 and BZ:2025523 (SatelliteQE#15205)
f1ead77 
Signed-off-by: Gaurav Talreja <[email protected]>
shubhamsg199 pushed a commit that referenced this pull request Jul 9, 2024
@Satellite-QE @Gauravtalreja1
[6.15.z] Add test coverage for BZ:2238952 and BZ:2025523 (#15455)
d7b12b2 
Add test coverage for BZ:2238952 and BZ:2025523 (#15205)

Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit c3d4f63)

Co-authored-by: Gaurav Talreja <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Add test coverage for BZ:2238952 and BZ:2025523 (SatelliteQE#15205)
ae62bf0 
Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR QETestCoverage Issues and PRs relating to a Satellite bug UI Issues and PRs involving the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravtalreja1 @Satellite-QE @shubhamsg199