Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phoenix team based codeowners #15048

Merged
merged 1 commit into from
May 14, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 13, 2024

Problem Statement

Right now we have generic teams like robottelo-tier-X-reviewers who are tagged to provide review based on the CODEOWNERS file. It would be nice to get a review request based on the team owning the particular file where the changes are proposed to.

Solution

This PR adds files owned by Phoenix team into CODEOWNERS, so @SatelliteQE/phoenix folks should get tagged automatically. We can add other teams too if this approach proves to be helpful in future.

@vsedmik vsedmik requested a review from a team May 13, 2024 16:15
@vsedmik vsedmik self-assigned this May 13, 2024
@vsedmik vsedmik requested a review from a team as a code owner May 13, 2024 16:15
@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 13, 2024
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Will allow me to make a seperate folder for just our team's work - the normal github notification pipeline is truly a fire hose

@JacobCallahan JacobCallahan merged commit 5651769 into SatelliteQE:master May 14, 2024
9 of 10 checks passed
github-actions bot pushed a commit that referenced this pull request May 14, 2024
@jyejare
Copy link
Member

jyejare commented May 14, 2024

Good to see this is being done even before we start discussing this in large audience. We can take it as a POC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants