Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] [CLI] Should not be able to publish CV, while added repo sync in-progress #15004

Merged
merged 1 commit into from
May 15, 2024
Merged

[RFE] [CLI] Should not be able to publish CV, while added repo sync in-progress #15004

merged 1 commit into from
May 15, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented May 8, 2024 •
edited
Loading

Problem Statement

PRT Case

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 8, 2024
@damoore044 damoore044 requested a review from a team May 8, 2024 19:32
@damoore044 damoore044 self-assigned this May 8, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@damoore044 damoore044 force-pushed the RFE_reposync_publish branch 2 times, most recently from 6350065 to 940ff54 Compare May 9, 2024 15:48
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: pytest tests/foreman/cli/test_contentview.py -k 'test_negative_publish_during_repo_sync'

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6867
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 9 warnings in 711.61s (0:11:51) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 9, 2024
vsedmik
vsedmik approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one non-blocking question.

tests/foreman/cli/test_contentview.py Outdated Show resolved Hide resolved
vijaysawant
vijaysawant approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6904
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 9 warnings in 837.04s (0:13:57) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 13, 2024
shweta83
shweta83 reviewed May 15, 2024
View reviewed changes
tests/foreman/cli/test_contentview.py Outdated
'url': settings.repos.rhel8_os.appstream,
}
)
content_view = module_target_sat.cli_factory.make_content_view(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use module_cv fixture here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just pushed!

@damoore044 damoore044 requested a review from a team as a code owner May 15, 2024 12:34
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6936
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_contentview.py::TestContentView::test_negative_publish_during_repo_sync --external-logging
Test Result : ================== 1 passed, 9 warnings in 705.80s (0:11:45) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 15, 2024
@damoore044
Copy link
Contributor Author

Most recent two pushes were for minor docstring changes ^

@vsedmik vsedmik merged commit 5473bea into SatelliteQE:master May 15, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request May 15, 2024
@damoore044 @web-flow
[RFE] [CLI] Should not be able to publish CV, while added repo sync i…
4681b7a 
…n-progress (#15004)

RFE CLI:reposync_publish

(cherry picked from commit 5473bea)
@Satellite-QE Satellite-QE mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 left review comments

@vsedmik vsedmik vsedmik approved these changes

@sambible sambible sambible approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@ColeHiggins2 ColeHiggins2 Awaiting requested review from ColeHiggins2

Assignees

@damoore044 damoore044

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damoore044 @Satellite-QE @sambible @vijaysawant @shweta83 @vsedmik