Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for BZ:2166466 #14914

Merged
merged 1 commit into from
May 6, 2024
Merged

Add test coverage for BZ:2166466 #14914

merged 1 commit into from
May 6, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

Problem Statement

Missing coverage for BZ:2166466/BZ:2242915, where we verified pagination on hostgroup edit page as per entries_per_page setting

Solution

Add coverage for BZ:2166466/BZ:2242915 to verify pagination on hostgroup create and edit page as per entries_per_page setting

Related Issues

Airgun PR SatelliteQE/airgun#1372

@Gauravtalreja1 Gauravtalreja1 added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 29, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Apr 29, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner April 29, 2024 15:04
@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 29, 2024
@Gauravtalreja1 Gauravtalreja1 force-pushed the ansible-hg-pagination branch 2 times, most recently from 9d58a88 to 0cea075 Compare April 29, 2024 17:51
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 29, 2024
@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 29, 2024
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination
airgun: 1372

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6737
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination --external-logging
Test Result : ========== 1 failed, 2 deselected, 15 warnings in 1425.99s (0:23:45) ===========

@lhellebr
Copy link
Contributor

PRT failing :(

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination
airgun: 1372

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6769
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination --external-logging
Test Result : ========== 1 passed, 2 deselected, 16 warnings in 1417.94s (0:23:37) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 2, 2024
lhellebr
lhellebr reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending one comment

tests/foreman/destructive/test_ansible.py Show resolved Hide resolved
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination
airgun: 1372

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 2, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6771
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ansible.py -k test_positive_hostgroup_ansible_roles_tab_pagination --external-logging
Test Result : ========== 1 passed, 2 deselected, 16 warnings in 1347.68s (0:22:27) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 2, 2024
@Gauravtalreja1
Add test coverage for BZ:2166466
8db0078 
Signed-off-by: Gaurav Talreja <[email protected]>
@Gauravtalreja1
Copy link
Collaborator Author

Just rebased the PR to resolve merge conflict, PRT is passing

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 3, 2024
@Gauravtalreja1 Gauravtalreja1 added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 3, 2024
@shubhamsg199 shubhamsg199 merged commit 5e0ca4c into SatelliteQE:master May 6, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request May 6, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:2166466 (#14914)
6672b3d 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 5e0ca4c)
@Satellite-QE Satellite-QE mentioned this pull request May 6, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 6, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:2166466 (#14914)
92599b8 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 5e0ca4c)
@Satellite-QE Satellite-QE mentioned this pull request May 6, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 6, 2024
@Gauravtalreja1 @web-flow
Add test coverage for BZ:2166466 (#14914)
ea2da32 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit 5e0ca4c)
@Satellite-QE Satellite-QE mentioned this pull request May 6, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 deleted the ansible-hg-pagination branch May 6, 2024 08:44
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Jun 14, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Add test coverage for BZ:2166466 (SatelliteQE#14914)
8b55e2d 
Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @lhellebr @shubhamsg199