[Customer Case] Test for creating a host with lce specified #14321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeHiggins2
added
CLI
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
lhellebr
reviewed
Mar 12, 2024
tests/foreman/cli/test_host.py
Outdated
| } | ||
| ) | ||
| hosts = module_target_sat.cli.Host.list({'organization-id': module_org.id}) | ||
| for i in hosts: |
There was a problem hiding this comment.
Use something like
assert 'string' in [item['name'] for item in list_of_something]
... and get rid of the unnecessary variable, loop and iterating through a dict!
lhellebr
reviewed
Mar 12, 2024
tests/foreman/cli/test_host.py
Outdated
| if new_host.name in i.values(): | ||
| found_host = True | ||
| break | ||
| assert found_host is True, 'Assertion failed: host not found' |
There was a problem hiding this comment.
- You can delete this using my comment above
- We don't do
assert x is True, justassert xis enough
Griffin-Sullivan
approved these changes
Mar 20, 2024
Satellite-QE
removed
the
PRT-Passed
|
trigger: test-robottelo |
vsedmik
approved these changes
Apr 8, 2024
Comment on lines
+2723
to
+2734
| found_host = any(new_host.name in i.values() for i in hosts) | ||
| assert found_host, 'Assertion failed: host not found' |
There was a problem hiding this comment.
Non-blocking
Suggested change
| found_host = any(new_host.name in i.values() for i in hosts) | |
| assert found_host, 'Assertion failed: host not found' | |
| assert any(new_host.name in i.values() for i in hosts), 'Assertion failed: host not found' |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
|
trigger: test-robottelo |
|
PRT Result |
sambible
approved these changes
May 6, 2024
pondrejk
reviewed
May 7, 2024
ColeHiggins2
force-pushed
the
hammer_host_create_lce
branch
from
b9b21f8
to
e284c84
Compare
Satellite-QE
removed
the
PRT-Passed
sambible
force-pushed
the
hammer_host_create_lce
branch
from
e284c84
to
1b127f3
Compare
ColeHiggins2
force-pushed
the
hammer_host_create_lce
branch
from
1b127f3
to
458e78d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Test for creating a host with lce specified * addressing comments * rebase and adding to docstring * fixing docstring issue (cherry picked from commit 4e13993)
pondrejk
pushed a commit
that referenced
this pull request
May 9, 2024
…15006) [Customer Case] Test for creating a host with lce specified (#14321) * Test for creating a host with lce specified * addressing comments * rebase and adding to docstring * fixing docstring issue (cherry picked from commit 4e13993) Co-authored-by: Cole Higgins <[email protected]>
jyejare
pushed a commit
to jyejare/robottelo
that referenced
this pull request
Oct 19, 2024
…eQE#14321) * Test for creating a host with lce specified * addressing comments * rebase and adding to docstring * fixing docstring issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
hammer host create did not previously support --lifecycle-environment options, only --lifecycle-environment-id
Now users should be able to create a host with --lifecycle-environment ['name'] set
Solution
Automation to create a host using the --lifecycle-environment option