Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ogajduse committed Apr 30, 2024
1 parent bed6d60 commit 9d648a7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions tests/foreman/api/test_errata.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _validate_errata_counts(host, errata_type, expected_value, timeout=120):
sleep(5)
else:
pytest.fail(
'Host {} contains {} {} errata, but expected to contain ' '{} of them'.format(
'Host {} contains {} {} errata, but expected to contain {} of them'.format(
host.name,
host.content_facet_attributes['errata_counts'][errata_type],
errata_type,
Expand All @@ -149,7 +149,7 @@ def _fetch_available_errata(host, expected_amount=None, timeout=120):
errata = host.errata()
else:
pytest.fail(
'Host {} contains {} available errata, but expected to ' 'contain {} of them'.format(
'Host {} contains {} available errata, but expected to contain {} of them'.format(
host.name,
len(errata['results']),
expected_amount if not None else 'No expected_amount provided',
Expand Down
4 changes: 2 additions & 2 deletions tests/foreman/api/test_notifications.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ def long_running_task(target_sat):
f"SET start_at = {sql_date_2_days_ago}, "
f" started_at = {sql_date_2_days_ago}, "
f" state_updated_at = {sql_date_2_days_ago} "
f"WHERE id='{job['task']['id']}';\nEOF\n\" "
)
f"WHERE id=\'{job['task']['id']}\';\nEOF\n\" "
) # fmt: skip # skip formatting to avoid breaking the SQL query
assert 'UPDATE 1' in result.stdout, f'Failed to age task {job["task"]["id"]}: {result.stderr}'

yield job
Expand Down
2 changes: 1 addition & 1 deletion tests/foreman/ui/test_ansible.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def _finalize():
result = rhel_contenthost.execute(command)
assert result.status == 0, f'Failed to register host: {result.stderr}'
target_host = rhel_contenthost.nailgun_host
default_value = '["test"]'
default_value = '[\"test\"]' # fmt: skip
parameter_type = 'array'
with target_sat.ui_session() as session:
session.organization.select(org_name=module_org.name)
Expand Down

0 comments on commit 9d648a7

Please sign in to comment.