Fix for registration command packages #1225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a space separated string not a list https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html
dosas
added
CherryPick
|
Can one of the admins verify this patch? |
| @@ -6792,7 +6792,7 @@ def __init__(self, server_config=None, **kwargs): | |||
| 'jwt_expiration': entity_fields.IntegerField(default=4), | |||
| 'repo': entity_fields.StringField(default=''), | |||
| 'repo_gpg_key_url': entity_fields.URLField(default=''), | |||
| 'packages': entity_fields.ListField(default=[]), | |||
| 'packages': entity_fields.StringField(), | |||
There was a problem hiding this comment.
@dosas Good catch, this field should only be a string field, but robottelo uses it as a list field only, will you be opening a PR for that too?
There was a problem hiding this comment.
Shouldn't some tests be failing if packages was passed?
I cannot find any usage of packages in robottelo tests.
RegistrationCommand is called by api_register : https://github.com/search?q=repo%3ASatelliteQE%2Frobottelo%20api_register&type=code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a space separated string not a list
https://apidocs.theforeman.org/foreman/latest/apidoc/v2/registration_commands/create.html