Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts section to pyproject.toml #39

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

synkd
Copy link
Collaborator

@synkd synkd commented Jun 4, 2024

When I converted Manifester to pyproject.toml, I did not include a project.scripts section. As a result, an executable for the Manifester CLI is not installed when the Manifester package is installed. This PR adds a project.scripts section to pyproject.toml so the Manifester CLI is easily accessible.

When I converted Manifester to pyproject.toml, I did not include a
`project.scripts` section. As a result, an executable for the Manifester
CLI is not installed when the Manifester package is installed. This PR
adds a `project.scripts` section to pyproject.toml so the Manifester CLI
is easily accessible.
@synkd synkd requested a review from JacobCallahan June 4, 2024 15:39
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a call to manifester --help in the GitHub action post-install?

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending Jake's comment.

@synkd
Copy link
Collaborator Author

synkd commented Jun 5, 2024

@JacobCallahan just to clarify, do you mean in the Unit Tests section of workflows/codeql-analysis.yml?

@JacobCallahan
Copy link
Member

@synkd if that's where you do the install, then definitely

  Command-line interface for manifester.

Options:
  --help  Show this message and exit.

Commands:
  delete        Delete subscription allocations in inventory and...
  get-manifest  Return a subscription manifester based on the settings...
  inventory     Display the local inventory file's contents. to codeql-analysis GitHub action
@synkd
Copy link
Collaborator Author

synkd commented Jun 6, 2024

@JacobCallahan I'm not totally certain which installation you're referring to, but Manifester gets installed in the Unit Tests section of the codeql-analysis GitHub Action and in the Setup and Build section of the python-publish GitHub Action. I've added a call to manifester --help to the former and can add it to the latter as well if you would like.

Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect. Just to validate that the basic cli works

@synkd synkd merged commit f29bb5f into SatelliteQE:master Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants