-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts
section to pyproject.toml
#39
Conversation
When I converted Manifester to pyproject.toml, I did not include a `project.scripts` section. As a result, an executable for the Manifester CLI is not installed when the Manifester package is installed. This PR adds a `project.scripts` section to pyproject.toml so the Manifester CLI is easily accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a call to manifester --help in the GitHub action post-install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, pending Jake's comment.
@JacobCallahan just to clarify, do you mean in the Unit Tests section of |
@synkd if that's where you do the install, then definitely |
Command-line interface for manifester. Options: --help Show this message and exit. Commands: delete Delete subscription allocations in inventory and... get-manifest Return a subscription manifester based on the settings... inventory Display the local inventory file's contents. to codeql-analysis GitHub action
@JacobCallahan I'm not totally certain which installation you're referring to, but Manifester gets installed in the Unit Tests section of the codeql-analysis GitHub Action and in the Setup and Build section of the python-publish GitHub Action. I've added a call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect. Just to validate that the basic cli works
When I converted Manifester to pyproject.toml, I did not include a
project.scripts
section. As a result, an executable for the Manifester CLI is not installed when the Manifester package is installed. This PR adds aproject.scripts
section to pyproject.toml so the Manifester CLI is easily accessible.