This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Added setup-default-docker task role #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris1984 can you please fix the issues as per these, https://github.com/SatelliteQE/ansible-satellite6/blob/master/CONTRIBUTING.md#standards For now, ignore the suggestion to remove the empty files. |
ehelms
reviewed
Jul 31, 2018
|
|
||
| - name: "Start docker service" | ||
| shell: service docker start | ||
| when: ansible_distribution_major_version < "7" |
There was a problem hiding this comment.
I think you can manage this block with https://docs.ansible.com/ansible/latest/modules/service_module.html
ehelms
reviewed
Jul 31, 2018
| - name: "Enable Docker service" | ||
| systemd: | ||
| name: docker.service | ||
| enabled: true |
There was a problem hiding this comment.
Should this be in the enable_docker task file?
ehelms
reviewed
Jul 31, 2018
| - include_tasks: docker_group.yml | ||
| - include_tasks: enable_docker.yml | ||
|
|
||
|
|
|
Naming wise, for me, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Ansible role for setup-default-docker Satellite 6 automation-tools task