Fix race condition in PF4 progressbar #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
dosas
force-pushed
the
fix-progress-bar-race-condition
branch
from
913a897
to
6653c45
Compare
when the progress bar disappears between the is_displayed query and the current_progress query a NoSuchElement exception is raised
dosas
force-pushed
the
fix-progress-bar-race-condition
branch
from
6653c45
to
452139b
Compare
omkarkhatavkar
approved these changes
Jul 4, 2024
|
@dosas Do you know any test that I can confirm for this feature? |
It is used when publishing 'new' content views so should be |
|
trigger: test-robottelo |
|
|
trigger: test-robottelo |
sambible
approved these changes
Jul 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
when the progress bar disappears between the is_displayed query and the current_progress query a NoSuchElement exception is raised (cherry picked from commit 1661b6c)
dosas
added a commit
to ATIX-AG/airgun
that referenced
this pull request
Jul 31, 2024
when the progress bar disappears between the is_displayed query and the current_progress query a NoSuchElement exception is raised (cherry picked from commit 1661b6c)
ogajduse
pushed a commit
that referenced
this pull request
Aug 16, 2024
when the progress bar disappears between the is_displayed query and the current_progress query a NoSuchElement exception is raised (cherry picked from commit 1661b6c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the progress bar disappears between the
is_displayed query and the current_progress query
a NoSuchElement exception is raised