Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.13.z] browser teardown fix at session exit #1414

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[6.13.z] browser teardown fix at session exit #1414

merged 1 commit into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. session: execute browser teardown only once (#1413) 

    The browser teardown in `airgun.session.Session.__exit__` should be executed only once.

Because when `Session` is nested in multiple context managers(*),
the `__exit__` method is called for each one
and this causes that the second and further `webdriver.quit()` call will fail,
because the browser session was already stopped.

(*) for example in the robottelo `session` fixture in `robottelo/pytest_fixtures/core/ui.py`.

(cherry picked from commit 6b6423e)
    @pnovotny @web-flow
    pnovotny authored and web-flow committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    963a54b View commit details
    Browse the repository at this point in the history