Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in repo discovery and search #1311

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Apr 5, 2024

While fixing some HTTP Proxy UI failures I discovered that in 6.15 and stream/6.16 the Discover button is not hit since it collides with the vertical nav menu search. Narrowing down the locator helps.

Also, session.repository.search(product_name, repo_name) now returns None since #1200 was merged. It does not feel like a PF4 searchbox in 6.15 and stream

image

Turning it back helped locally.

@vsedmik vsedmik requested review from dosas and pondrejk April 5, 2024 14:40
@vsedmik vsedmik self-assigned this Apr 5, 2024
@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z 6.15.z labels Apr 5, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Apr 5, 2024

PRT passed SatelliteQE/robottelo#14646 (comment)

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Ack

Copy link
Collaborator

@dosas dosas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, this fixes my issue mentioned here

@sambible sambible merged commit 9b6592c into SatelliteQE:master Apr 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z 6.14.z 6.15.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants