[6.15.z] Navigation search: input clear fix #1234
Conversation
More sophisticated approach for clearing the search input. Sometimes the previous value still remained in the search input, even when clear() was called several times in a row. This was probably a timing issue when running on a rel. fast browser machine. (cherry picked from commit 37bf497)
Satellite-QE
added
6.15.z
Auto_Cherry_Picked
Satellite-QE
added
the
AutoMerge_Cherry_Picked
|
trigger: test-robottelo |
airgun/widgets.py
Outdated
| @@ -856,7 +856,7 @@ class PF4NavSearch(PF4Search): | |||
| search_button = Button(locator=(".//button[@aria-label='Search']")) | |||
| clear_button = Button(locator=(".//button[@aria-label='Reset']")) | |||
There was a problem hiding this comment.
| clear_button = Button(locator=(".//button[@aria-label='Reset']")) | |
| clear_button = PF4Button(locator=(".//button[@aria-label='Reset']")) |
Change the class of the button to the PF4Button.
It needs to be imported:
from widgetastic_patternfly4 import Button as PF4Button
and if imported like this, you need to also change the import on line 30 from:
from widgetastic_patternfly4.ouia import BaseSelect, Button as PF4Button, Dropdown, Menu
to
from widgetastic_patternfly4.ouia import BaseSelect, Button as OUIAButton, Dropdown, Menu
and then change the former occurrences of PF4Button to OUIAButton
There was a problem hiding this comment.
@LadislavVasina1 nice find, @pnovotny can you please also update the same in the master as well?
There was a problem hiding this comment.
@omkarkhatavkar sure. I will create new PR for master because the #1233 was alerady merged.
Vertical menu search buttons should use the correct PF4 button widgets. This fixes the search clearing issue, when a search text value pops back after clearing the search input via browser.clear() The original PF4Button import alias was renamed to OUIAButton.
|
PRT passed on SatelliteQE/robottelo#14077, Could you fix the pre-commit? |
|
The pre-commit is now finally passing. |
Cherrypick of PR: #1233
More sophisticated approach for clearing the search input.
Sometimes the previous value still remained in the search input,
even when
clear()was called several times in a row.This was probably a timing issue when running on a rel. fast browser machine.