-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardware model delete functionality (6.15.z) #1231
Conversation
c183268
to
4d6c671
Compare
The Actions header in the table was removed The delete action is now accessible via an svg
4d6c671
to
28d415e
Compare
@lhellebr @jameerpathan111 @LadislavVasina1 @pondrejk Can anyone from your team run these PRT tests for this PR? |
Have you verified this change is intended? |
trigger: test-robottelo |
The mentioned test will still fail since there is a follow up error:
The error fixed within this PR is about not being able to open the delete pop-up |
@dosas Thanks for giving the fix for this. I verified the test. It seems there there is failure in case of deleting the already used model with wrong error message. While I was still able to record the test execution see that delete it working okay. |
@dosas will wait for any other opinion, else we will merge this PR. |
The test fails with error
That's an issue unrelated to the PR that should be fixed:
|
Despite the label this was never cherry-picked into 6.15.z. Does somebody know what went wrong? |
The Actions header in the table was removed The delete action is now accessible via an svg SatelliteQE#1231
The Actions header in the table was removed The delete action is now accessible via an svg SatelliteQE#1231
For foreman 3.9 (6.15.z) the 'Actions' header string was removed (see picture):
The delete action is now accessible via an svg.
This should fix https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/ui/test_hardwaremodel.py