Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardware model delete functionality (6.15.z) #1231

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Feb 8, 2024

For foreman 3.9 (6.15.z) the 'Actions' header string was removed (see picture):

hardware_models

The delete action is now accessible via an svg.

This should fix https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/ui/test_hardwaremodel.py

@omkarkhatavkar omkarkhatavkar added the CherryPick PR needs CherryPick to previous branches label Feb 9, 2024
airgun/widgets.py Outdated Show resolved Hide resolved
The Actions header in the table was removed
The delete action is now accessible via an svg
@omkarkhatavkar
Copy link

@lhellebr @jameerpathan111 @LadislavVasina1 @pondrejk Can anyone from your team run these PRT tests for this PR?

@lhellebr
Copy link
Contributor

lhellebr commented Feb 16, 2024

Have you verified this change is intended?
Where else is this used, what tests should we run PRT for? Just ui/test_hardwaremodel.py::test_positive_end_to_end?

@lhellebr
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_hardwaremodel.py::test_positive_end_to_end

@dosas
Copy link
Collaborator Author

dosas commented Feb 19, 2024

The mentioned test will still fail since there is a follow up error:

AssertionError: assert_message: failed to find matching notifications. Available notifications: []

The error fixed within this PR is about not being able to open the delete pop-up

@omkarkhatavkar
Copy link

@dosas Thanks for giving the fix for this. I verified the test. It seems there there is failure in case of deleting the already used model with wrong error message. While I was still able to record the test execution see that delete it working okay.

@omkarkhatavkar
Copy link

@dosas will wait for any other opinion, else we will merge this PR.

@lhellebr
Copy link
Contributor

The test fails with error Request failed with status code 422 because the hardware model is already in use. Actually, a different error is expected:

        if err_message:
            view.flash.assert_message(f"Danger alert: {err_message}")

That's an issue unrelated to the PR that should be fixed:

  1. A correct error message should be expected
  2. The message should say what the problem was, not just 422

@omkarkhatavkar omkarkhatavkar merged commit faac944 into SatelliteQE:master Feb 20, 2024
5 of 6 checks passed
@dosas
Copy link
Collaborator Author

dosas commented Mar 12, 2024

Despite the label this was never cherry-picked into 6.15.z. Does somebody know what went wrong?

dosas added a commit to ATIX-AG/airgun that referenced this pull request Mar 12, 2024
The Actions header in the table was removed
The delete action is now accessible via an svg

SatelliteQE#1231
dosas added a commit to ATIX-AG/airgun that referenced this pull request Mar 18, 2024
The Actions header in the table was removed
The delete action is now accessible via an svg

SatelliteQE#1231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants