Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind sql injection vulnerabilities secure implementations #477

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Blind sql injection vulnerabilities secure implementations #477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a1a3e
Add blindSQL secure implementation level 4
imertetsu Oct 31, 2024
145c1a3
Add blindSQL secure implementation level 5
imertetsu Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions ...java/org/sasanlabs/service/vulnerability/sqlInjection/BlindSQLInjectionVulnerability.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.sasanlabs.service.vulnerability.sqlInjection;

import java.util.Map;
import javax.persistence.EntityManager;
import javax.persistence.PersistenceContext;
import org.sasanlabs.internal.utility.LevelConstants;
import org.sasanlabs.internal.utility.Variant;
import org.sasanlabs.internal.utility.annotations.AttackVector;
Expand Down Expand Up @@ -29,6 +31,7 @@
value = "BlindSQLInjectionVulnerability")
public class BlindSQLInjectionVulnerability {

@PersistenceContext private EntityManager entityManager;
private JdbcTemplate applicationJdbcTemplate;

static final String CAR_IS_PRESENT_RESPONSE = "{ \"isCarPresent\": true}";
Expand Down Expand Up @@ -106,4 +109,49 @@ public ResponseEntity<String> getCarInformationLevel3(
ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
});
}
// Input Validation - Ensure that the input data is valid and of the expected type.
@VulnerableAppRequestMapping(
value = LevelConstants.LEVEL_4,
variant = Variant.SECURE,
htmlTemplate = "LEVEL_1/SQLInjection_Level1")
public ResponseEntity<String> getCarInformationLevel4(
@RequestParam Map<String, String> queryParams) {
String id = queryParams.get(Constants.ID);

// Validate numeric ID
if (!id.matches("\\d+")) {
return ResponseEntity.status(HttpStatus.BAD_REQUEST).body("Invalid ID format.");
}

BodyBuilder bodyBuilder = ResponseEntity.status(HttpStatus.OK);
bodyBuilder.body(ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
return applicationJdbcTemplate.query(
"select * from cars where id=" + id,
(rs) -> {
if (rs.next()) {
return bodyBuilder.body(CAR_IS_PRESENT_RESPONSE);
}
return bodyBuilder.body(
ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
});
}

// Implementation Level 5 - Hibernate
@VulnerableAppRequestMapping(
value = LevelConstants.LEVEL_5,
variant = Variant.SECURE,
htmlTemplate = "LEVEL_1/SQLInjection_Level1")
public ResponseEntity<String> getCarInformationLevel5(
@RequestParam Map<String, String> queryParams) {
int id = Integer.parseInt(queryParams.get(Constants.ID));

CarInformation car = entityManager.find(CarInformation.class, id);

if (car != null) {
return ResponseEntity.ok(CAR_IS_PRESENT_RESPONSE);
} else {
return ResponseEntity.status(HttpStatus.NOT_FOUND)
.body(ErrorBasedSQLInjectionVulnerability.CAR_IS_NOT_PRESENT_RESPONSE);
}
}
}
Loading