-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3109: Bumps FitProblem fix #3110
Conversation
…s object. Update to match the new functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but I still get this message when trying to fit.
File "sas\qtgui\Perspectives\Fitting\FittingWidget.py", line 2115, in fitComplete
AttributeError: 'str' object has no attribute 'fitness'
python setup.py clean | ||
python setup.py build | ||
mv build/lib/sasdata/example_data/* ../sasview/src/sas/example_data/ | ||
mv sasdata/example_data/* ../sasview/src/sas/example_data/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to actually remove example_data
from the sasdata source directory during the build step?
Should you not just cp -r
the thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this build:
@rozyczko - The fitting error is expected. This work, as noted in the pull request, only gets SasView to build and launch with the latest version of bumps. There is an outstanding issue how fitting packages parameters and what bumps expects. |
Alternatively, we can use the last release of bumps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does look good as the first step in solving the interoperability issue.
If you are running from source, the local repo takes precedence over any installed version. If you have pulled from bumps master recently, this is likely why you are seeing this. 6.0.0 builds should be using bumps v0.9.2. |
Description
This uses the new interface for bumps where every fit problem is multi-fit. Iterating through the models now directly returns the fitness object instead of the individual fit problem. This change brings SasView in line with this new behavior.
This only fixes the majority of the issues related to this major change. Fits will continue to fail, but this PR allows the app to build and launch. See the issue for more info.
Refs #3109
Review Checklist:
Licencing (untick if necessary)