Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2993 ascii file reader options #3007

Draft
wants to merge 296 commits into
base: refactor_24
Choose a base branch
from
Draft

2993 ascii file reader options #3007

wants to merge 296 commits into from

Conversation

jamescrake-merani
Copy link
Contributor

Created a prototype dialog menu for selecting various parameters for reading in an ASCII dataset file.

@jamescrake-merani
+ not * for 1 or more.
0dcf738
@jamescrake-merani
Function to guess starting position.
18323fe
@jamescrake-merani
Fill table on some events.
1f0ebbc
@jamescrake-merani
Use new function for guessing starting pos.
3953928
@jamescrake-merani
Fixed typo.
b0ad077
@jamescrake-merani
Correct expression.
a2914a5
@jamescrake-merani
Ignore minus sign as well.
31ef0f1
@jamescrake-merani
Strip before splitting.
39f77cc
@jamescrake-merani
Still show hidden items but grey them out.
74d3063
@jamescrake-merani
Get the current dataset type.
4f7a484
@jamescrake-merani
Use the options for the dataset type.
bfc4829
@jamescrake-merani
Method to replace options.
3ad48df
@jamescrake-merani
Change options when dataset changes.
d522004
@jamescrake-merani
Automagically set an assumed col order.
ad3d716
@jamescrake-merani
Ignore index errors.
80a211c
@jamescrake-merani
Whoops exception handling in wrong place.
ef2d4d1
@jamescrake-merani
Change when the event handler has happened.
3075594 
Stops it from triggering early.
@jamescrake-merani
Update columns.
1307eec
@jamescrake-merani
Fixed bug when user doesn't select a file.
d92a870
@jamescrake-merani
Filename wrong part of the result.
35757f0
@jamescrake-merani
Comment is more descriptive.
e911bc2
@jamescrake-merani
Fixed options updates.
4b04b13
@jamescrake-merani
Set editable to true for all boxes.
2af64d4
@jamescrake-merani
Removed todo comment.
3b9068b
@jamescrake-merani
Validator for the columns.
745e8fb
@jamescrake-merani
Get the unit widgit to show up next to the col.
db9d44f
@jamescrake-merani
Changed replacing options.
b1c0714
@jamescrake-merani
Fix set_col_order.
2d68063
@jamescrake-merani
Fixerd col_names function.
72b8141
@jamescrake-merani
Created the ColumnUnit widgit.
ff5e293
@jamescrake-merani
Changed name to be more consistent.
ad35b79
@jamescrake-merani
Add a custom entry button to the layout.
3ac829a
@jamescrake-merani
Use a signal for when the custom button is pressed
0d1304b
@jamescrake-merani
Started with the selector widget.
381ac0e
@jamescrake-merani
Hook up event handlers properly.
4e86f4c
@jamescrake-merani
Use the generic selector widget.
3848319
@jamescrake-merani
Init the base class.
4a69c86
@jamescrake-merani
Forgot to pass self into layout.
b7ccb0a
@jamescrake-merani
Handle when there is no new widget.
420c9e5
@jamescrake-merani
Use isinstance.
74bd1d7
@jamescrake-merani
Fixed event handling.
16d8493
@jamescrake-merani
Layout not inited properly.
55af567
@jamescrake-merani
Need to delete, and reassign selector widget.
605fff6
@jamescrake-merani
This line shouldn't be here.
f5eb7a5
@jamescrake-merani
Set the title of the metadata dialog.
bb3c506
@jamescrake-merani
Use separate functions for creating these widgets.
88b61c8
@jamescrake-merani
Use the new function.
ffdbc11
@jamescrake-merani
Removed comment that doesn't make sense anymore.
7aeef6a
@jamescrake-merani
Handle value changes.
c7cb4a6
@jamescrake-merani
Pass in the new args.
869edbd
@jamescrake-merani
Fixed typos in comments.
4bc0111
@jamescrake-merani
Choose default widget based on current option.
26d3bca
@jamescrake-merani
Set the field from the already set metadata.
c22cff1
@jamescrake-merani
Wrong control.
53a9df1
@jamescrake-merani
Pass raw_metadata into params.
82c633d
@jamescrake-merani
This should be a TODO comment.
bcf3ea7 
So it doesn't get lost.
@jamescrake-merani
Updated this map with a todo warning.
8ad0054
@jamescrake-merani
Gonna try a different approach.
189115f
@jamescrake-merani
Fixed bug where not editing metadata wouldn't work
2c7f19c
@jamescrake-merani
Strip all of the lines.
0f42252 
Was causing bugs with ASCII data that has trailing, and leading whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-wilkins lucas-wilkins lucas-wilkins left review comments

@rozyczko rozyczko rozyczko left review comments

@pkienzle pkienzle pkienzle left review comments

Assignees

@lucas-wilkins lucas-wilkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamescrake-merani @rozyczko @pkienzle @lucas-wilkins