resolved comments

Sarthak-Shaha · Sep 24, 2024 · a531374 · a531374
1 parent 11989d5
commit a531374
Show file tree

Hide file tree

Showing 5 changed files with 164 additions and 182 deletions.
diff --git a/examples/air-quality-sensor-app/silabs/include/AirQualityConfig.h b/examples/air-quality-sensor-app/silabs/include/AirQualityConfig.h
@@ -33,7 +33,7 @@
 #define VERY_POOR_THRESHOLD 250
 
 // <o EXTREMELY_POOR_THRESHOLD> Extremely Poor Threshold Value
-// <i> Default: 2147483647
+// <i> Default: 300
 #define EXTREMELY_POOR_THRESHOLD 300
 
 // <<< end of configuration section >>>

diff --git a/examples/air-quality-sensor-app/silabs/include/AirQualitySensorUI.h b/examples/air-quality-sensor-app/silabs/include/AirQualitySensorUI.h
@@ -22,7 +22,6 @@
 #include "dmd.h"
 #include "glib.h"
 #include "lcd.h"
-#include <CommonIcons.h>
 
 class AirQualitySensorUI
 {

diff --git a/examples/air-quality-sensor-app/silabs/src/SensorManager.cpp b/examples/air-quality-sensor-app/silabs/src/SensorManager.cpp
@@ -102,9 +102,9 @@ CHIP_ERROR SensorManager::Init()
 
     PlatformMgr().LockChipStack();
     ChipLogDetail(AppServer, "Int instnace");
-    AirQualitySensorManager::InitInstance(1);
-    ChipLogDetail(AppServer, "Int instnace success");
+    AirQualitySensorManager::InitInstance();
     PlatformMgr().UnlockChipStack();
+    ChipLogDetail(AppServer, "Int instnace success");
     // Create cmsisos sw timer for air quality sensor timer.
     mSensorTimer = osTimerNew(SensorTimerEventHandler, osTimerPeriodic, nullptr, nullptr);
     if (mSensorTimer == NULL)
@@ -167,9 +167,9 @@ void SensorManager::SensorTimerEventHandler(void * arg)
 
     PlatformMgr().LockChipStack();
     AirQualitySensorManager::GetInstance()->OnAirQualityChangeHandler(classifyAirQuality(air_quality));
-
-    AppTask::GetAppTask().UpdateAirQualitySensorUI();
     PlatformMgr().UnlockChipStack();
+
+    AppTask::GetAppTask().UpdateAirQualitySensorUI();
 
     ChipLogDetail(AppServer, "RAW AirQuality value: %ld and corresponding Enum value : %d", air_quality,
                   chip::to_underlying(AirQualitySensorManager::GetInstance()->GetAirQuality()));