-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] WIP: Initial Action and StatusEffect implementation #958
Merged
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
7f70248
Check statuses to determine valid lut entry
arieshi255 114bd28
Add duration field to statuses
arieshi255 65ad14a
Rename buildEffects to make more sense
arieshi255 0cd43df
Add basic generic handler for applying statuseffects
arieshi255 ed4104c
Add more modifiers
arieshi255 dd20478
Add basic modifier impl for Chara
arieshi255 c15ac90
Apply/remove modifiers for statuseffects
arieshi255 5386f13
Add some example statuses to lut
arieshi255 b94e7f4
Fix windows build error
arieshi255 b3098fe
Don't clear tick effect
arieshi255 b525495
Add status entry for Maim
arieshi255 bfaec90
Apply status effects properly for self when having a target
arieshi255 7ad9f96
Fix hasStatusEffect to prevent duplicates
arieshi255 51b7740
Basic dot/hot ticks implemented
arieshi255 78acb58
Update HP on tick effects
arieshi255 6fce046
Apply effect to correct target
arieshi255 6cbf94d
Add method to simplify applying statuses to self
arieshi255 801fc9d
Merge pull request #915 from Skyliegirl33/actions
SapphireMordred aaad18b
Add job actions for warrior
arieshi255 b56aab7
Add some actions and statuses for war
arieshi255 995bce4
Add even more modifiers
arieshi255 390a53a
Add statuseffect cost type
arieshi255 b5c603a
Add option to not send statusremove order
arieshi255 ec3c109
Change delModifier assert to return early instead
arieshi255 9daf224
Add option for scripts to enable the generic/lut handler
arieshi255 ade5cfa
Add enums for common action values
arieshi255 b4cd677
fix indentation
arieshi255 8d08234
Fix modifier name for Defiance
arieshi255 df4977c
Remove status tick logging
arieshi255 4870b0b
Merge pull request #919 from Skyliegirl33/actions-war
SapphireMordred 38a0cd1
Move modifiers to statuseffect
arieshi255 f12e7ec
Add ParryPercent modifier
arieshi255 df9c51f
Remove wrath when Defiance ends
arieshi255 ff0a1c8
Apply modifiers in applyStatus
arieshi255 cf32d4f
Remove unused method
arieshi255 f4a3c94
Persistence for cross-class skills
arieshi255 5bb8f11
Add flags to StatusEffects
arieshi255 293c281
Some exd struct fixes
arieshi255 49486f5
Some aoe work
arieshi255 63d9ce5
Add flags to lut
arieshi255 3f30027
Add missing changeclass
arieshi255 fb65f72
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 a92076b
Add SET_STATUS_ME to ActionIntegrity
arieshi255 6e30be3
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 8337d5d
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 8bd74ba
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 f001ee1
Improve offensive action check
arieshi255 a612516
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 12f289e
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 db9d106
Add flag to overloaded applyStatusEffectSelf
arieshi255 434eaa6
indentation fix
arieshi255 9b3e793
Merge pull request #920 from Skyliegirl33/actions-war
SapphireMordred 83590fc
Some calculation work
arieshi255 97e1772
Merge upstream
arieshi255 cc63ac1
Null-check ActionResultBuilder
arieshi255 390426a
Merge branch 'master' of https://github.com/SapphireServer/Sapphire i…
arieshi255 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE `characlass` ADD `BorrowAction` binary(40) DEFAULT NULL NULL AFTER `Lvl`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why : 8 ? it is already an 8 bit value.