Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to publish a continuous release #380

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

nicola02nb
Copy link
Contributor

@nicola02nb nicola02nb commented Nov 25, 2024

Changes made

Created a CI workflow files that compiles and publish a "Continuos build" on every push to master branch.

This gives users a way to get the latest features without building the project on their own

You can check the result on my fork

Checklist

  • I adjusted the README (if needed)
  • For new features in HeadsetControl: I discussed it beforehand in Issues or Discussions and adhered to the wiki

@nicola02nb nicola02nb changed the title Add CI workflows publish a continuous release Add CI workflow to publish a continuous release Nov 29, 2024
@Sapd
Copy link
Owner

Sapd commented Dec 4, 2024

Thank you! Great contribution.

I thought also of doing something like this. Currently Windows Builds are in fact pushed but hidden inside the artifcats window.

Just two points:

  • Would it make sense to include it already in the existing flows? I myself guess not bc. this one is just excluded on push. Just something to think about
  • Does the Release automatically replace other releases named "continous"?

Also there could be a question about signing releases (as there was before from AUR contributors), but I am not sure how it would work in a flow as that. Currently the normal releases are manually signed by myself.

@nicola02nb
Copy link
Contributor Author

nicola02nb commented Dec 4, 2024

  • Does the Release automatically replace other releases named "continous"?

It shouldn't replace latest release, it just creates a new pre-release, tagged as continuous

Let me check

EDIT:

Removes latest continuosus tagged release

@nicola02nb
Copy link
Contributor Author

  • Would it make sense to include it already in the existing flows? I myself guess not bc. this one is just excluded on push. Just something to think about

In my opinion makes sense so users have an easier way to access to latest features before release wihout needing to search through CI arctifacts...

@nicola02nb
Copy link
Contributor Author

Also there could be a question about signing releases (as there was before from AUR contributors), but I am not sure how it would work in a flow as that. Currently the normal releases are manually signed by myself.

I dont know much about signing releases... I can only say that my idea was ment only for pre-release which should not need signing? I guess you can do it when you create the official release?

@Sapd Sapd merged commit 689c1fc into Sapd:master Dec 6, 2024
5 checks passed
@Sapd
Copy link
Owner

Sapd commented Dec 6, 2024

In my opinion makes sense so users have an easier way to access to latest features before release wihout needing to search through CI arctifacts...

I agree

I dont know much about signing releases... I can only say that my idea was ment only for pre-release which should not need signing? I guess you can do it when you create the official release?

I think that is fine, it could be added afterwards when its requested and really needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants