Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capabilities for Artic Nova 7 mirophone(tested and working) and… #356

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

nicola02nb
Copy link
Contributor

@nicola02nb nicola02nb commented Jun 10, 2024

… volume limiter(tested and working); pre inserted instruction for bluetooth capabilities(tested,not working)

Changes made

Added features for Steelseries Artic Nova 7:

  • microphone mute led brightness
  • microphone volume
  • volume limiter

Pre added instructions to main.c, device.h and device.c for possible future implementation of:

  • bluetooth when powered on
  • bluetooth call volume

Checklist

  • I adjusted the README (if needed)
  • For new features in HeadsetControl: I discussed it beforehand in Issues or Discussions and adhered to the wiki

@Sapd
Copy link
Owner

Sapd commented Jun 10, 2024

I will do a make format before merging so dont worry about the code style.

The other commented out functions dont work at all?

src/device.c Outdated
Comment on lines 55 to 57
[CAP_VOLUME_LIMITER] = 'g'//,
//[CAP_BT_WHEN_POWERED_ON] = 'h',
//[CAP_BT_CALL_VOLUME] = 'c'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capabilities_str_short is basically used for the deprecated short output future.

I think I will replace it with \0 for the new features, and add a check here

for (int j = 0; j < info->capabilities_amount; j++) {
that it does not output something on \0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capabilities_str_short is basically used for the deprecated short output future.

I think I will replace it with \0 for the new features, and add a check here

for (int j = 0; j < info->capabilities_amount; j++) {

that it does not output something on \0

There I've putted some random letters as a placeholder... if you want to remove them after my edits, you're free to do it.

@nicola02nb
Copy link
Contributor Author

I will do a make format before merging so dont worry about the code style.

The other commented out functions dont work at all?

Oh cool, I will totally check it.

I tried the other functions, but they were not working... I try to see if they are an easy fix, but I haven't any experience on wireshark... may
be it's time to give it a shot.

@nicola02nb
Copy link
Contributor Author

I also forgot to put the help section for the new command...

@nicola02nb
Copy link
Contributor Author

Updated the branch with new working features... I didn't got make format working, I hope it doesn't give any problem with the clang-format

src/main.c Outdated Show resolved Hide resolved
@nicola02nb
Copy link
Contributor Author

Can you explain me line 32 of the code style ceck?

@Sapd
Copy link
Owner

Sapd commented Jun 10, 2024

Can you explain me line 32 of the code style ceck?

Yeah there is a whitespace at the end of the line

-    if (num == 8) <-- here
+    if (num == 8)

But does not really matter, I will also fix the enum from above later and then also re run a format over it

@nicola02nb
Copy link
Contributor Author

Can you explain me line 32 of the code style ceck?

Yeah there is a whitespace at the end of the line

-    if (num == 8) <-- here
+    if (num == 8)

But does not really matter, I will also fix the enum from above later and then also re run a format over it

Oh 😅

@nicola02nb
Copy link
Contributor Author

Any info on first error?

@Sapd
Copy link
Owner

Sapd commented Jun 10, 2024

Looks fine to me. I think the whitespace check is quite simple and just does a diff to the commit before. It just sees that there is a diff and that its why it outputs it. It will probably go away when I merge it later.

@nicola02nb
Copy link
Contributor Author

nicola02nb commented Jun 10, 2024

Ok, I hope I wasn't an issue with all this commits 😅

nicola02nb and others added 2 commits June 11, 2024 21:52
New device features:
- volume limiter
- bluetooth when powered on
- bluetooth call volume
- Update README with new features
- Don't add short output info for new features
- Remove double option
- Increase API version
@Sapd Sapd force-pushed the missing-fatures-artic-nova-7 branch from 62a0b95 to 0bec212 Compare June 11, 2024 19:54
@Sapd Sapd merged commit b340ebc into Sapd:master Jun 11, 2024
5 checks passed
@Sapd
Copy link
Owner

Sapd commented Jun 11, 2024

Thank you! well done

@Sapd Sapd linked an issue Jun 11, 2024 that may be closed by this pull request
@nicola02nb nicola02nb deleted the missing-fatures-artic-nova-7 branch June 13, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Volume Limiter Support
2 participants