Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image size in PDF post export #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaishnavi-2301
Copy link

@vaishnavi-2301 vaishnavi-2301 commented Oct 8, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Screenshots, Recordings

Screenshot 2024-10-08 at 4 18 28 PM

Tested Feature??

  • In Real Device.
  • In Emulator

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@SankethBK
Copy link
Owner

Hi @vaishnavi-2301 , the reason for converting from delta to markdown and then to HTML was i couldn't find a library which directly converts from delta to HTML. The library handles lot of formatting stuff which would be difficult to write manually. If you remove that part, lot of other formatting like headings, lists, .. won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix image size in PDF
3 participants