Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declutter settings page #223

Merged
merged 23 commits into from
Oct 7, 2024
Merged

declutter settings page #223

merged 23 commits into from
Oct 7, 2024

Conversation

devpawann
Copy link
Contributor

@devpawann devpawann commented Oct 4, 2024 •
edited by SankethBK
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Move some settings options from SettingsPage to SettingsDetailPage.

Related Tickets & Documents

Screenshots, Recordings

Tested Feature??

  • In Real Device.
  • In Emulator

@SankethBK
Copy link
Owner

SankethBK commented Oct 4, 2024 •
edited
Loading

Hi, this is correct, just small suggestions:

  1. Keep SetupAccount widget in SettingsDetailPage itself at the top.
  2. Move the "AutoSaveToggleButton" from Reminders to cloud backup.
  3. Remove Daily Reminders expandable tile and show the options directly just like you did for Security Settings.

Also you missed the "export notes" section, make a separate tile "Import and Export Notes" below "Customize Theme, Fonts and Language", remove the expandable tile and show the options directly for this also.

@devpawann
Copy link
Contributor Author

devpawann commented Oct 7, 2024 •
edited
Loading

  1. Do you mean place SetupAccount in the outer page SettingsPage ?
  2. Done
  3. Done
  4. Export notes done - I didn't see Import note implementation though
    @SankethBK

@SankethBK
Copy link
Owner

Do you mean place SetupAccount in the outer page SettingsPage ?

yes

Export notes done - I didn't see Import note implementation though

Its not there yet, planning to add it.

@devpawann
Copy link
Contributor Author

@SankethBK
You can now review

Prakharpan-dey and others added 5 commits October 7, 2024 23:42
@Prakharpan-dey @SankethBK
In-App Review Modal (SankethBK#222)
8685256 
* Normalize line endings

* Added in-app review

* Added In-App Review Modal

* Update .gitignore

* Updated Logger

* Changes Logger to printer
@SankethBK
Revert "Update firebase config"
77e4b68 
This reverts commit 46c6135.
@SankethBK
padding fixes
2beb0c2
@SankethBK
Merge branch 'master' into 218-declutter-settings-page
04212fe
@SankethBK
Merge branch 'master' into 218-declutter-settings-page
50ad55a
SankethBK
SankethBK approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@SankethBK SankethBK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I added some minor changes related to padding.

@SankethBK SankethBK merged commit 5a5ecea into SankethBK:master Oct 7, 2024
3 checks passed
SankethBK pushed a commit that referenced this pull request Oct 11, 2024
@devpawann @SankethBK
declutter settings page (#223)
22c9b79 
Declutter settings page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SankethBK SankethBK SankethBK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declutter Settings Page
3 participants
@devpawann @SankethBK @Prakharpan-dey