fix: minutes in tag packets and tag server commands #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seconds are only one byte big and not two, so the Minutes start at byte 3 and not 4.
Broadcast() with a sender never sends the packet to the sender. Therefore only other players got informed about the new role. But never the actual player that is supposed to change to that role.
|
Maybe the SmoOnlineServer/Shared/Packet/Packets/TagPacket.cs Lines 7 to 12 in bec6dde Works fine with Code in the client for reference. |
Sanae6
approved these changes
Jun 21, 2024
Istador
commented
Jun 21, 2024
There was a problem hiding this comment.
✔️ I tested in-game that the tag updates and commands still function properly with a Size of 5.
(The current client doesn't keep the time for longer than a frame, and doesn't update the role icon, but these are client bugs that I already fixed in my local version I'm working on for the client.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.