Ignore players after the MaxPlayers limit is reached ; Crash ignored players on stage changes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Istador
commented
Apr 27, 2024
•
Istador
commented
- Banned players are ignored, but they still send all their packages - mostly positional updates - to the server, so it's better to crash them to avoid unnecessary traffik.
- And after reaching the max players setting, clients trying to connect are disconnected. The automatic reconnect will flood the server and its log with repeated connection attempts (as was the case with banned players in the past), so it's better to ignore and crash them as well.
Sanae6
approved these changes
Apr 27, 2024
|
Fix conflicts and then I'll merge it 👍 |
- use brackets when possible - set client.Id and client.Name earlier - use client.Id instead of header.Id - rename firstConn to isClientNew
To make service discovery by internet scan bots harder.
Otherwise they keep sending all their packets (including positional updates) to the server which costs bandwidth and processing power.
…ayers limit Otherwise they'll enter an endless disconnect-reconnnect loop spamming the server with new TCP connections.
Istador
force-pushed
the
crash-ignored-players
branch
from
ee1fd23 to
b661cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.