Fixed a bug that the style palettes were not being loaded due an incorrect DOM event #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheb60
changed the title
|
@daftspunk said that it should use condition depending by turbo router Can you test it and i can merge this PR 💯 |
It indeed should use the condition depending by turbo router. Added compatibility by daftspunk request.
|
@Samuell1 I added the condition as requested and it seems to work in both scenarios 👍 . Would be great if you can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that the custom style palettes were not being loaded on the front-end. Swapped the page:loaded event for DOMContentLoaded because page:loaded is a custom event. Now the custom style palettes are being loaded correctly.