Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add more tests #301

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

kulcsaradam
Copy link
Contributor

This is just a demonstration of expanding the testing system of Walrus.
Add tests:

  • regression: random tests
  • malformed: incorrect syntax tests
  • standalone: feature tests (with heavy wasi utilization)
  • proposal_features: features that are only just proposed in some way (for example anyref and array type)

This will be changed to fit the right licenses, it is just a demonstration.

@zherczeg
Copy link
Collaborator

zherczeg commented Nov 8, 2024

Thank you! We can discuss what kind of tests we want to run. For example, malformed tests are testing wabt, do we need them?

Signed-off-by: Ádám Kulcsár <[email protected]>
Move wamr tests to 'tests/other' directory and restructure the wamr test runner into a standalone file.

Signed-off-by: Ádám Kulcsár <[email protected]>
@clover2123
Copy link
Collaborator

Thanks for your great contribution!
Please consider the followings:

  • What about merging tools/run-tests-other.py into tools/run-tests.py file?
  • IMO we don't need to run tests for proposed-features

@kulcsaradam
Copy link
Contributor Author

Initially we just wanted the files to be seperated so it's easier to keep track of "other" tests but I will merge it if that is prefered.
Also if proposed-feature tests are not really needed then we can remove them, it was just in case if we implemented any of them then they could be tested instantly.

The section 'target_features' needs to be implemented to work with wasi-clang
compilation.
Add build_programs.py.

Signed-off-by: Ádám László Kulcsár <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants