Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass more test cases on test262 #655

Merged
merged 2 commits into from
May 11, 2020
Merged

Pass more test cases on test262 #655

merged 2 commits into from
May 11, 2020

Conversation

ksh8281
Copy link
Contributor

@ksh8281 ksh8281 commented May 11, 2020

No description provided.

* Object.prototype.toLocaleString should use this value correctly
* ICU 67 doesn't format near minus zero value correctly, so we should disable test
* we should provide stack info correctly when there is try-statemenet

Signed-off-by: Seonghyun Kim <[email protected]>
@ksh8281
Copy link
Contributor Author

ksh8281 commented May 11, 2020

This patch disables some test262 cases due to #654

Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123 clover2123 merged commit a9a41ff into Samsung:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants