os/drivers/serial: avoid board sleep in UART RX #6485
Conversation
This commit make use of PM APIs to avoid board sleep during uart_recvchars operation. This will ensure UART RX IRQ can be handled by application without board sleep.
gSahitya-samsung
force-pushed
the
pm_uart
branch
from
81020bd
to
e2480c5
Compare
|
Test Results : Building and booting is fine. |
| dev->received(dev); | ||
| #ifdef CONFIG_PM | ||
| /* Enable board sleep after completing received operation */ | ||
| (void)pm_resume(pm_uart_domain_id); |
There was a problem hiding this comment.
it should be in serial_read().
| @@ -75,6 +75,12 @@ | |||
| * Pre-processor Definitions | |||
| ************************************************************************************/ | |||
|
|
|||
| /* The UART Domain name, that needs to register with PM */ | |||
There was a problem hiding this comment.
A header in os/include is for outside usages. But only serial uses those two definitions inside. Let's move them in some header in os/drivers/serial.
| DEBUGASSERT(pm_uart_domain_id != -1); | ||
| /* Suspend board sleep if application is wating for UART data */ | ||
| (void)pm_suspend(pm_uart_domain_id); | ||
| #endif | ||
| dev->received(dev); |
There was a problem hiding this comment.
This will just post a semaphore and not perform the actual read operation. So, pm can still go into sleep if we resume here. pm_resume must be called at the end of uart_read when we know that the app has actually read the data.
This commit make use of PM APIs to avoid board sleep during uart_recvchars operation. This will ensure UART RX IRQ can be handled by application without board sleep.