Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/mec] Read const_element_count_limit from setting #14382

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

batcheu
Copy link
Contributor

@batcheu batcheu commented Nov 29, 2024

The value of 'const_element_count_limit' will be used to determine number of data in tensor to be shown.


The value of 'const_element_count_limit' will be used to determine
number of data in tensor to be shown.

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <[email protected]>
@@ -40,6 +40,8 @@ def __init__(self):
v: k
for k, v in circle_schema.TensorType.__dict__.items()
}
# Number of elements to show in tensor values (default: 16)
self.config_element_size = 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added code below is used const_element_count_limit,

        if settings.get('const_element_count_limit'):
            self.const_element_count_limit = settings['const_element_count_limit']

but, this is config_element_size. are they variables for different purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed to update it while I change the variable name.
Thanks 👍

ONE-DCO-1.0-Signed-off-by: Jonghwa Lee <[email protected]>
Copy link
Contributor

@ys44kim ys44kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 5a24685 into Samsung:master Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants