[onert] Introduce tests for Reshape, Squeeze and ExpandDims #14227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds more tests for Reshape, Squeeze and ExpandDims. The purpose is to cover the cases where memory copying of those ops can be skipped. ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
zetwhite
reviewed
Oct 24, 2024
| int reshape_out = cgen.addTensor({{2, 2}, circle::TensorType::TensorType_FLOAT32}); | ||
| int cos2_out = cgen.addTensor({{2, 2}, circle::TensorType::TensorType_FLOAT32}); | ||
|
|
||
| cgen.addOperatorCos({{input}, {cos1_out}}); |
There was a problem hiding this comment.
Just for curiosity,
Is there a specific reason to choose cos operator?
Did you choose cos because it is element-wise operator - which works without additional arguments?
There was a problem hiding this comment.
This cos node is needed just to not set Reshape input/output as a input/output of the whole model (in such a case sharing memory is disabled). But I see your confusion so I've wrapped it in helper function.
There was a problem hiding this comment.
But I see your confusion so I've wrapped it in helper function.
Sorry, I've forgot to push the code last time ;)
zetwhite
approved these changes
Oct 31, 2024
|
@mbencer Please add negative test: same or more negative test with positive test to fulfill release criteria. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds more tests for Reshape, Squeeze and ExpandDims. The purpose is to cover the cases where memory copying of those ops can be skipped.
ONE-DCO-1.0-Signed-off-by: Mateusz Bencer [email protected]
Draft: #14057