[onert/core] Fix ShapeValidator of RmsNorm #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes ShapeValidator of RmsNorm to allow rank 3 input and single gamma. ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
zetwhite
reviewed
Oct 14, 2024
Comment on lines
1136
to
1138
| auto ifm_shape = operands.at(ifm_index).shape(); | ||
| auto ofm_shape = operands.at(ofm_index).shape(); | ||
| auto gamma_shape = operands.at(gamma_index).shape(); |
There was a problem hiding this comment.
(optional) How about adding const reference?
Suggested change
| auto ifm_shape = operands.at(ifm_index).shape(); | |
| auto ofm_shape = operands.at(ofm_index).shape(); | |
| auto gamma_shape = operands.at(gamma_index).shape(); | |
| const auto& ifm_shape = operands.at(ifm_index).shape(); | |
| const auto& ofm_shape = operands.at(ofm_index).shape(); | |
| const auto& gamma_shape = operands.at(gamma_index).shape(); |
There was a problem hiding this comment.
(optional) How about adding
const reference?
Okay, I'll update it :)
zetwhite
reviewed
Oct 14, 2024
| auto ofm_shape = operands.at(ofm_index).shape(); | ||
| auto gamma_shape = operands.at(gamma_index).shape(); | ||
|
|
||
| OP_REQUIRES(ifm_shape.rank() == 3 || ifm_shape.rank() == 4); |
There was a problem hiding this comment.
IDK the background, Is there a reason to support input with rank==3?
There was a problem hiding this comment.
IDK the background, Is there a reason to support input with
rank==3?
Current testing model has "rank = 3" inputs, like A x B x C.
Fixes variables to be const in RmsNorm ShapeValidator. ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
zetwhite
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes ShapeValidator of RmsNorm to allow rank 3 input and single gamma.
ONE-DCO-1.0-Signed-off-by: Seockho Kim [email protected]
issue: #14089
draft: #14088