[one-cmds] Add substitute_expand_dims_to_reshape to one command #14205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's add substitute_expand_dims_to_reshape to one command. ONE-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
|
plz add links to draft and/or issue
I'll approve this PR after I see above two tests are passed in draft PR. why? we need to check each pass is working as expected with integration tests. |
jinevening
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
The code ifself looks good to me.
Please address #14205 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add substitute_expand_dims_to_reshape to one command.
ONE-DCO-1.0-Signed-off-by: Dayoung Lee [email protected]
DRAFT: #14164